You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (JIRA)" <ji...@apache.org> on 2010/10/06 22:16:30 UTC
[jira] Created: (AVRO-678) implement ReflectData#compare()
implement ReflectData#compare()
-------------------------------
Key: AVRO-678
URL: https://issues.apache.org/jira/browse/AVRO-678
Project: Avro
Issue Type: Sub-task
Components: java
Reporter: Doug Cutting
Fix For: 1.5.0
Order comparison is not implemented for reflected data. It ought to be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-678) implement ReflectData#compare()
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-678:
------------------------------
Assignee: Doug Cutting
Hadoop Flags: [Incompatible change]
Status: Patch Available (was: Open)
This is incompatible, since protected getField and setField methods have moved to a different class. This may affect folks who've implemented a DatumReader or DatumWriter that overrides or calls these methods.
> implement ReflectData#compare()
> -------------------------------
>
> Key: AVRO-678
> URL: https://issues.apache.org/jira/browse/AVRO-678
> Project: Avro
> Issue Type: Sub-task
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-678.patch
>
>
> Order comparison is not implemented for reflected data. It ought to be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-678) implement ReflectData#compare()
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-678:
------------------------------
Attachment: AVRO-678.patch
Here's a patch that implements this, with tests. It also moves getField() and setField() methods from the reader/writers to GenericData, so that the generic implementation of record comparison can be shared. This also eliminates some duplicate code.
> implement ReflectData#compare()
> -------------------------------
>
> Key: AVRO-678
> URL: https://issues.apache.org/jira/browse/AVRO-678
> Project: Avro
> Issue Type: Sub-task
> Components: java
> Reporter: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-678.patch
>
>
> Order comparison is not implemented for reflected data. It ought to be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (AVRO-678) implement ReflectData#compare()
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated AVRO-678:
------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this.
> implement ReflectData#compare()
> -------------------------------
>
> Key: AVRO-678
> URL: https://issues.apache.org/jira/browse/AVRO-678
> Project: Avro
> Issue Type: Sub-task
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.5.0
>
> Attachments: AVRO-678.patch
>
>
> Order comparison is not implemented for reflected data. It ought to be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.