[GitHub] [spark] srowen commented on a diff in pull request #36473: [SPARK-37618][CORE][Followup] Support cleaning up shuffle blocks from external shuffle service

[GitBox <gi...@apache.org>]

srowen commented on code in PR #36473:
URL: https://github.com/apache/spark/pull/36473#discussion_r867041332


##########
core/src/test/scala/org/apache/spark/storage/DiskBlockManagerSuite.scala:
##########
@@ -141,28 +142,48 @@ class DiskBlockManagerSuite extends SparkFunSuite with BeforeAndAfterEach with B
     assert(attemptId.equals("1"))
   }
 
+  // Use jnr to get and override the current process umask.
+  // Expects the input mask to be an octal number
+  private def getAndSetUmask(posix: POSIX, mask: String): String = {
+    val prev = posix.umask(BigInt(mask, 8).toInt)

Review Comment:
   Is there any existing utility for setting umask? I thought Hadoop APIs had this somewhere and that we use it. No big deal if not. But if we have other places we use umask, could be good to standardize



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org