You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2015/07/07 12:09:43 UTC

Review Request 36253: HIVE-11171

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36253/
-----------------------------------------------------------

Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran.


Bugs: HIVE-11171
    https://issues.apache.org/jira/browse/HIVE-11171


Repository: hive-git


Description
-------

Join reordering algorithm might introduce projects between joins


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinCommuteRule.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7fd8c85 
  ql/src/test/results/clientpositive/auto_join12.q.out e97d7e6 
  ql/src/test/results/clientpositive/auto_join5.q.out 69b7aab 
  ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out 40d2dd4 
  ql/src/test/results/clientpositive/correlationoptimizer15.q.out d5f45da 
  ql/src/test/results/clientpositive/correlationoptimizer6.q.out 85e447c 
  ql/src/test/results/clientpositive/join12.q.out df340a8 
  ql/src/test/results/clientpositive/join5.q.out f83ff73 
  ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out b73643e 
  ql/src/test/results/clientpositive/join_merging.q.out a3afbec 
  ql/src/test/results/clientpositive/join_nulls.q.out 46e0170 
  ql/src/test/results/clientpositive/limit_pushdown.q.out 6ace047 
  ql/src/test/results/clientpositive/lineage3.q.out 5c392fa 
  ql/src/test/results/clientpositive/louter_join_ppr.q.out c46792b 
  ql/src/test/results/clientpositive/optional_outer.q.out 8616644 
  ql/src/test/results/clientpositive/outer_join_ppr.q.java1.7.out b6ca16f 
  ql/src/test/results/clientpositive/ppd_gby_join.q.out 579c827 
  ql/src/test/results/clientpositive/ppd_join.q.out ae5fb27 
  ql/src/test/results/clientpositive/ppd_join2.q.out 88624ea 
  ql/src/test/results/clientpositive/ppd_join3.q.out 6c5c0da 
  ql/src/test/results/clientpositive/ppd_outer_join4.q.out 18e0154 
  ql/src/test/results/clientpositive/ppd_random.q.out 5e23a1c 
  ql/src/test/results/clientpositive/rcfile_null_value.q.out a1e6f4f 
  ql/src/test/results/clientpositive/router_join_ppr.q.out 70d7542 
  ql/src/test/results/clientpositive/skewjoin.q.out 1b56d5f 
  ql/src/test/results/clientpositive/spark/auto_join12.q.out 1bddcfc 
  ql/src/test/results/clientpositive/spark/auto_join5.q.out 08e9ae6 
  ql/src/test/results/clientpositive/spark/join12.q.out b62334d 
  ql/src/test/results/clientpositive/spark/join5.q.out 1914ad0 
  ql/src/test/results/clientpositive/spark/join_merge_multi_expressions.q.out a18d82e 
  ql/src/test/results/clientpositive/spark/join_merging.q.out ce26543 
  ql/src/test/results/clientpositive/spark/limit_pushdown.q.out 7101beb 
  ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 190485f 
  ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.7.out 0614cb9 
  ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out 31b25b3 
  ql/src/test/results/clientpositive/spark/ppd_join.q.out b97431c 
  ql/src/test/results/clientpositive/spark/ppd_join2.q.out cf81423 
  ql/src/test/results/clientpositive/spark/ppd_join3.q.out d2343c4 
  ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 2abca78 
  ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 12f1abb 
  ql/src/test/results/clientpositive/spark/skewjoin.q.out ec74786 
  ql/src/test/results/clientpositive/tez/explainuser_1.q.out 9f93574 
  ql/src/test/results/clientpositive/tez/limit_pushdown.q.out 2a41aae 
  ql/src/test/results/clientpositive/tez/mrr.q.out d42f9b0 
  ql/src/test/results/clientpositive/tez/skewjoin.q.out ec368f9 
  ql/src/test/results/clientpositive/tez/tez_union.q.out 4012b90 

Diff: https://reviews.apache.org/r/36253/diff/


Testing
-------

Existing tests


Thanks,

Ashutosh Chauhan

Re: Review Request 36253: HIVE-11171

Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36253/#review90686
-----------------------------------------------------------

Ship it!


Ship It!

- Jesús Camacho Rodríguez


On July 7, 2015, 10:09 a.m., Ashutosh Chauhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36253/
> -----------------------------------------------------------
> 
> (Updated July 7, 2015, 10:09 a.m.)
> 
> 
> Review request for hive, Jesús Camacho Rodríguez and John Pullokkaran.
> 
> 
> Bugs: HIVE-11171
>     https://issues.apache.org/jira/browse/HIVE-11171
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Join reordering algorithm might introduce projects between joins
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinCommuteRule.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 7fd8c85 
>   ql/src/test/results/clientpositive/auto_join12.q.out e97d7e6 
>   ql/src/test/results/clientpositive/auto_join5.q.out 69b7aab 
>   ql/src/test/results/clientpositive/constantPropagateForSubQuery.q.out 40d2dd4 
>   ql/src/test/results/clientpositive/correlationoptimizer15.q.out d5f45da 
>   ql/src/test/results/clientpositive/correlationoptimizer6.q.out 85e447c 
>   ql/src/test/results/clientpositive/join12.q.out df340a8 
>   ql/src/test/results/clientpositive/join5.q.out f83ff73 
>   ql/src/test/results/clientpositive/join_merge_multi_expressions.q.out b73643e 
>   ql/src/test/results/clientpositive/join_merging.q.out a3afbec 
>   ql/src/test/results/clientpositive/join_nulls.q.out 46e0170 
>   ql/src/test/results/clientpositive/limit_pushdown.q.out 6ace047 
>   ql/src/test/results/clientpositive/lineage3.q.out 5c392fa 
>   ql/src/test/results/clientpositive/louter_join_ppr.q.out c46792b 
>   ql/src/test/results/clientpositive/optional_outer.q.out 8616644 
>   ql/src/test/results/clientpositive/outer_join_ppr.q.java1.7.out b6ca16f 
>   ql/src/test/results/clientpositive/ppd_gby_join.q.out 579c827 
>   ql/src/test/results/clientpositive/ppd_join.q.out ae5fb27 
>   ql/src/test/results/clientpositive/ppd_join2.q.out 88624ea 
>   ql/src/test/results/clientpositive/ppd_join3.q.out 6c5c0da 
>   ql/src/test/results/clientpositive/ppd_outer_join4.q.out 18e0154 
>   ql/src/test/results/clientpositive/ppd_random.q.out 5e23a1c 
>   ql/src/test/results/clientpositive/rcfile_null_value.q.out a1e6f4f 
>   ql/src/test/results/clientpositive/router_join_ppr.q.out 70d7542 
>   ql/src/test/results/clientpositive/skewjoin.q.out 1b56d5f 
>   ql/src/test/results/clientpositive/spark/auto_join12.q.out 1bddcfc 
>   ql/src/test/results/clientpositive/spark/auto_join5.q.out 08e9ae6 
>   ql/src/test/results/clientpositive/spark/join12.q.out b62334d 
>   ql/src/test/results/clientpositive/spark/join5.q.out 1914ad0 
>   ql/src/test/results/clientpositive/spark/join_merge_multi_expressions.q.out a18d82e 
>   ql/src/test/results/clientpositive/spark/join_merging.q.out ce26543 
>   ql/src/test/results/clientpositive/spark/limit_pushdown.q.out 7101beb 
>   ql/src/test/results/clientpositive/spark/louter_join_ppr.q.out 190485f 
>   ql/src/test/results/clientpositive/spark/outer_join_ppr.q.java1.7.out 0614cb9 
>   ql/src/test/results/clientpositive/spark/ppd_gby_join.q.out 31b25b3 
>   ql/src/test/results/clientpositive/spark/ppd_join.q.out b97431c 
>   ql/src/test/results/clientpositive/spark/ppd_join2.q.out cf81423 
>   ql/src/test/results/clientpositive/spark/ppd_join3.q.out d2343c4 
>   ql/src/test/results/clientpositive/spark/ppd_outer_join4.q.out 2abca78 
>   ql/src/test/results/clientpositive/spark/router_join_ppr.q.out 12f1abb 
>   ql/src/test/results/clientpositive/spark/skewjoin.q.out ec74786 
>   ql/src/test/results/clientpositive/tez/explainuser_1.q.out 9f93574 
>   ql/src/test/results/clientpositive/tez/limit_pushdown.q.out 2a41aae 
>   ql/src/test/results/clientpositive/tez/mrr.q.out d42f9b0 
>   ql/src/test/results/clientpositive/tez/skewjoin.q.out ec368f9 
>   ql/src/test/results/clientpositive/tez/tez_union.q.out 4012b90 
> 
> Diff: https://reviews.apache.org/r/36253/diff/
> 
> 
> Testing
> -------
> 
> Existing tests
> 
> 
> Thanks,
> 
> Ashutosh Chauhan
> 
>