[GitHub] [groovy] sonatype-lift[bot] commented on a change in pull request #1659: GROOVY-10398: LazyFieldNode never equals itself

[GitBox <gi...@apache.org>]

sonatype-lift[bot] commented on a change in pull request #1659:
URL: https://github.com/apache/groovy/pull/1659#discussion_r759861555



##########
File path: src/test/org/codehaus/groovy/ast/decompiled/FieldNodeEqualityTest.groovy
##########
@@ -0,0 +1,40 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package org.codehaus.groovy.ast.decompiled
+
+import org.codehaus.groovy.ast.FieldNode
+import org.codehaus.groovy.control.CompilerConfiguration
+import org.junit.Test
+
+final class FieldNodeEqualityTest {
+    @Test
+    void testEquality() {
+        FieldNode fn1 = FieldNode.newStatic(CompilerConfiguration, 'JDK11')
+        assert fn1.equals(fn1)
+        FieldNode fn2 = new LazyFieldNode(() -> fn1, 'JDK11')
+        assert fn1.equals(fn2)
+        assert fn2.equals(fn1)
+        assert fn2.equals(fn2)

Review comment:
       *ComparisonWithSelf:*  Comparing an object to itself is useless and may indicate a bug: fn2.equals(fn2)
   (at-me [in a reply](https://help.sonatype.com/lift/talking-to-lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org