[GitHub] 100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #8997: Pie chart adds filterValue parameter
URL: https://github.com/apache/incubator-echarts/pull/8997#discussion_r225532737
 
 

 ##########
 File path: src/chart/pie/PieView.js
 ##########
 @@ -211,7 +211,20 @@ piePieceProto.updateData = function (data, idx, firstCreate) {
     graphic.setHoverStyle(this);
 };
 
-piePieceProto._updateLabel = function (data, idx) {
+piePieceProto._getFilterIgnore = function(data, idx) {
+    var seriesModel = data.hostModel;
+    var itemModel = data.getItemModel(idx);
+    var valueDim = data.mapDimension('value');
+    var sum = data.getSum(valueDim);
+    var filterValue = seriesModel.get('labelDisplayThreshold');
+    var filterIgnore = false;
+    if (sum * filterValue.option > itemModel.option.value) {
 
 Review comment:
   does `seriesModel.get('labelDisplayThreshold')` returns an `object`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org