You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:54:32 UTC

[GitHub] [nuttx] acassis commented on a diff in pull request #8026: Add mm map

acassis commented on code in PR #8026:
URL: https://github.com/apache/nuttx/pull/8026#discussion_r1061450789


##########
include/nuttx/mm/map.h:
##########
@@ -43,7 +49,11 @@ struct mm_map_entry_s
   off_t offset;
   int prot;
   int flags;
-  FAR void *priv;
+  union
+  {
+    FAR void *p;
+    int i;

Review Comment:
   @jlaitine @xiaoxiang781216 good point about uintptr_t, note that it is widespread in many places inside nuttx/drivers/, nuttx/wireless/ and even inside nuttx/tools/. Since we are not testing it on any board that really requires C89, what you think if we force the NuttX Simulator to use C89?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org