You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Reranko05 (via GitHub)" <gi...@apache.org> on 2026/06/26 07:45:37 UTC

[PR] GH-50231: Handle unset Substrait extension mapping type [arrow]

Reranko05 opened a new pull request, #50263:
URL: https://github.com/apache/arrow/pull/50263

   ### Rationale for this change
   
   A malformed Substrait `SimpleExtensionDeclaration` with an unset `mapping_type` currently reaches `Unreachable()`, causing the process to abort during deserialization. Since this can be triggered by malformed input, the deserializer should instead return an `Invalid` status.
   
   ### What changes are included in this PR?
   
   * Replace the `Unreachable()` call in `GetExtensionSetFromMessage` with a `Status::Invalid` return for unset or unknown `mapping_type` values.
   * Add a regression test to verify that deserializing a Substrait plan containing an empty `SimpleExtensionDeclaration` returns an `Invalid` status instead of aborting.
   
   ### Are these changes tested?
   
   Yes. A regression test covering the malformed `SimpleExtensionDeclaration` case has been added to `serde_test.cc`.
   
   ### Are there any user-facing changes?
   
   No.
   
   **This PR contains a "Critical Fix".**
   
   This change prevents process termination when deserializing malformed Substrait plans or expressions by returning a proper error instead of calling `std::abort()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50231: [C++] Handle unset Substrait extension mapping type [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50263:
URL: https://github.com/apache/arrow/pull/50263#issuecomment-4825170642

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 29c9361cc40ce6525f12dc8cad87898995c14ad9.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/83884668732) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50231: [C++] Handle unset Substrait extension mapping type [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #50263:
URL: https://github.com/apache/arrow/pull/50263


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50231: Handle unset Substrait extension mapping type [arrow]

Posted by "Reranko05 (via GitHub)" <gi...@apache.org>.
Reranko05 commented on PR #50263:
URL: https://github.com/apache/arrow/pull/50263#issuecomment-4815360147

   @kou Whenever you have some time, I'd really appreciate it if you could take a look at this PR.
   
   The Substrait tests are passing, but there are two remaining CI failures (arrow-s3fs-test timeout on ARM64 macOS and the Python Sphinx/Numpydoc job). From what I can tell, they don't appear to be related to this change, but I'd appreciate your thoughts. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org