You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/04 18:24:27 UTC

[GitHub] [arrow] bkietz commented on pull request #10070: ARROW-12231: [C++][Python][Dataset] Differentiate one-shot datasets

bkietz commented on pull request #10070:
URL: https://github.com/apache/arrow/pull/10070#issuecomment-832149506


   To me, this seems less like a subclass of dataset and more like a subclass of Scanner: IMHO it's not intuitive that a dataset would ever be single-shot. Instead, I think it'd make more sense to add `Scanner::MakeFromRecordBatchReader` or so, and (probably) add single-shot-ness to the contract of Scanner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org