You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/08 23:32:48 UTC

[GitHub] [superset] rusackas commented on pull request #15568: refactor: icon to icons for controls

rusackas commented on pull request #15568:
URL: https://github.com/apache/superset/pull/15568#issuecomment-876808656


   I think the question of whether or not we should render the relevant icon for the particular dataset is an interesting one. I can see both sides of the argument. If I were forced to choose a side, I'd say I would _personally_ lean toward making it accurately reflect the dataset. 
   
   _However_ this is not the intent of this PR! And it's clearly a bit contentious. We're waging a war to migrate to a new component, and this PR hits the mark. I agree the change we're discussing is worth the discussion... but maybe we should do that on an Issue/slack/zoom/etc, and open a separate PR if we want to pursue it after further discussion.
   
   Merging this one for now... baby steps :D 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org