You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/31 08:42:13 UTC

[GitHub] [rocketmq] mxsm opened a new issue, #4738: Semantic some variables value in BrokerController#initializeBrokerScheduledTasks method

mxsm opened a new issue, #4738:
URL: https://github.com/apache/rocketmq/issues/4738

   as following(BrokerController#initializeBrokerScheduledTasks):
   ![image](https://user-images.githubusercontent.com/15797831/182017716-4395273b-3d70-450c-9f0f-13286d52f623.png)
   The variable period is used for schedule fixed rate one day to execute. if we replace with the following code
   ```java
   final long period = TimeUnit.DAYS.toMillis(1);
   ```
   The Code looks cleaner and more elegant. You can understand the meaning at a glance when read the source code
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq] RongtongJin closed issue #4738: Semantic some variables value in BrokerController#initializeBrokerScheduledTasks method

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #4738: Semantic some variables value in BrokerController#initializeBrokerScheduledTasks method
URL: https://github.com/apache/rocketmq/issues/4738


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org