[jira] Commented: (MPWAR-16) war plugin cannot add other files to web-inf without workaround

[ji...@codehaus.org]

The following comment has been added to this issue:

     Author: Brett Porter
    Created: Wed, 14 Jan 2004 4:43 PM
       Body:
do you really need this?

struts-config.xml can live directly in WEB-INF to start with.

If you want to filter it as a resource, you can always use the standard resources and have it in /WEB-INF/classes, which you can then reference in web.xml instead.

If you are transforming struts-config.xml with XSLT, you'll need maven.xml anyway, and you can probably do that in place on target/webappname/WEB-INF

What do you think?
---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=MPWAR-16


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPWAR-16
    Summary: war plugin cannot add other files to web-inf without workaround
       Type: Improvement

     Status: Open
   Priority: Major

 Original Estimate: 30 minutes
 Time Spent: Unknown
  Remaining: 30 minutes

    Project: maven-war-plugin

   Assignee: Jason van Zyl
   Reporter: Tim Chen

    Created: Wed, 14 Jan 2004 4:33 PM
    Updated: Wed, 14 Jan 2004 4:43 PM
Environment: maven 1.0 rc-1
war plugin 1.4 and 1.5 SNAPSHOT

Description:
Consider a struts war which might have:

WEB-INF/
  web.xml
  struts-config.xml

The current war plugin does not allow you to copy struts-config.xml into WEB-INF without a maven.xml postgoal hack.

A possible patch would be to add the following to war:webapp

<ant:copy todir="${webapp.build.webinf}">
   <ant:fileset dir="${maven.war.webxml.src}"
       includes="${maven.war.webxml.src.includes}"
       excludes="${maven.war.webxml.src.excludes}"/>
</ant:copy>

an example project.properties using this would be:
maven.xdoc.date=left
maven.xdoc.version=${pom.currentVersion}
maven.multiproject.type=war

maven.xdoclet.webdoclet.destDir=${maven.build.dir}/xdoclet/webdoclet/WEB-INF
maven.xdoclet.webdoclet.mergeDir=${maven.src.dir}/merge
maven.xdoclet.webdoclet.fileset.0.include=**/*.java
maven.xdoclet.webdoclet.strutsconfigxml.0=true
maven.xdoclet.webdoclet.strutsconfigxml.0.Version=1.1
maven.xdoclet.webdoclet.strutsconfigxml.0.mergeDir=${maven.src.dir}/merge
maven.xdoclet.webdoclet.jsptaglib.0=false

maven.war.src=${maven.xdoclet.webdoclet.dir}
maven.war.webxml=${maven.xdoclet.webdoclet.destDir}/web.xml
maven.war.webxml.src=${maven.xdoclet.webdoclet.destDir}
maven.war.webxml.src.includes=struts*.xml

The proposed patch could be enhanced by ignoring web.xml if it is in the same directory etc.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org