Re: [PR] Add "serverId" and "privateKey" SCM parameters [maven-release]

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #1385:
URL: https://github.com/apache/maven-release/pull/1385#discussion_r2539928486


##########
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/AbstractScmReadReleaseMojo.java:
##########
@@ -167,11 +125,11 @@ protected ReleaseDescriptorBuilder createReleaseDescriptor() {
             }
         }
 
-        // As long as Scm.getId() does not exist, read it as a property
-        descriptor.setScmId(project.getProperties().getProperty("project.scm.id"));
+        descriptor.setScmId(serverId);
 
         for (MavenProject reactorProject : session.getProjects()) {
-            if (reactorProject.getScm() != null) {
+            if (reactorProject.getOriginalModel() != null
+                    && reactorProject.getOriginalModel().getScm() != null) {

Review Comment:
   This is a cause for: #1420, now `originalScmInfo` only contains project with defined scm info. 
   The change is ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org