[GitHub] [nifi-minifi-cpp] thenatog commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…

[GitBox <gi...@apache.org>]

thenatog commented on a change in pull request #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…
URL: https://github.com/apache/nifi-minifi-cpp/pull/610#discussion_r305866307
 
 

 ##########
 File path: extensions/http-curl/client/HTTPClient.cpp
 ##########
 @@ -148,6 +161,52 @@ void HTTPClient::setDisableHostVerification() {
   curl_easy_setopt(http_session_, CURLOPT_SSL_VERIFYHOST, 0L);
 }
 
+bool HTTPClient::setSpecificSSLVersion(SSLVersion specific_version) {
+#if CURL_AT_LEAST_VERSION(7, 54, 0)
+  CURLcode ret = CURLE_UNKNOWN_OPTION;
+  switch (specific_version) {
+    case SSLVersion::SSLv2:
+      ret = curl_easy_setopt(http_session_, CURLOPT_SSLVERSION, CURL_SSLVERSION_SSLv2);
 
 Review comment:
   Correct. NiFi currently only supports TLS v1.2 for incoming connections and has backward compatibility to use TLS v1.0 and v1.1 for outgoing connections to support legacy systems. We recommend taking this approach.
   
   This page notes the changes and when they occurred:
   https://cwiki.apache.org/confluence/display/NIFI/Migration+Guidance

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services