You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@royale.apache.org by Alex Harui <ah...@adobe.com.INVALID> on 2018/09/04 07:19:40 UTC
Re: [royale-asjs] branch feature/new_merge updated: This was causing
an RTE before the data was set.
This shouldn't be necessary. The Binding subsystem should catch and ignore null pointer exceptions.
My 2 cents,
-Alex
On 9/4/18, 12:12 AM, "harbs@apache.org" <ha...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
harbs pushed a commit to branch feature/new_merge
in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cbf6a15de3cb443d7c6e408d61235cdad%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636716419649648281&sdata=geSefiiIbLn7fLUT%2BmxuCxMYUdH%2FNdYnA5qxXTWgfIg%3D&reserved=0
The following commit(s) were added to refs/heads/feature/new_merge by this push:
new b4faf90 This was causing an RTE before the data was set.
b4faf90 is described below
commit b4faf9074de70fd8cce9cd6754960aca23be5bdd
Author: Harbs <ha...@in-tools.com>
AuthorDate: Tue Sep 4 10:12:28 2018 +0300
This was causing an RTE before the data was set.
---
.../src/main/royale/itemRenderers/IconListItemRenderer.mxml | 2 +-
.../src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml b/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
index 0f14474..3705753 100644
--- a/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
+++ b/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
@@ -47,7 +47,7 @@ limitations under the License.
<js:ItemRendererDataBinding />
</j:beads>
- <js:FontIcon text="{iconList.icon}" material="true" visible="{iconList.icon != null}" click="clickCloseButton()"/>
+ <js:FontIcon text="{iconList.icon}" material="true" visible="{iconList && iconList.icon != null}" click="clickCloseButton()"/>
<html:Span text="{iconList.label}"/>
diff --git a/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml b/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
index 7cf6f77..84e6bf0 100644
--- a/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
+++ b/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
@@ -39,7 +39,7 @@ limitations under the License.
<js:ItemRendererDataBinding />
</j:beads>
- <js:FontIcon text="{navlink.icon}" material="true" visible="{navlink.icon != null}"/>
+ <js:FontIcon text="{navlink.icon}" material="true" visible="{navlink && navlink.icon != null}"/>
<html:Span text="{navlink.label}"/>
Re: [royale-asjs] branch feature/new_merge updated: This was causing
an RTE before the data was set.
Posted by Harbs <ha...@gmail.com>.
You’re right.
I was pausing on caught exceptions and I didn’t realize the exception was caught…
> On Sep 4, 2018, at 10:19 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>
> This shouldn't be necessary. The Binding subsystem should catch and ignore null pointer exceptions.
>
> My 2 cents,
> -Alex
>
> On 9/4/18, 12:12 AM, "harbs@apache.org" <ha...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> harbs pushed a commit to branch feature/new_merge
> in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cbf6a15de3cb443d7c6e408d61235cdad%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636716419649648281&sdata=geSefiiIbLn7fLUT%2BmxuCxMYUdH%2FNdYnA5qxXTWgfIg%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/feature/new_merge by this push:
> new b4faf90 This was causing an RTE before the data was set.
> b4faf90 is described below
>
> commit b4faf9074de70fd8cce9cd6754960aca23be5bdd
> Author: Harbs <ha...@in-tools.com>
> AuthorDate: Tue Sep 4 10:12:28 2018 +0300
>
> This was causing an RTE before the data was set.
> ---
> .../src/main/royale/itemRenderers/IconListItemRenderer.mxml | 2 +-
> .../src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml b/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
> index 0f14474..3705753 100644
> --- a/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
> +++ b/examples/royale/JewelExample/src/main/royale/itemRenderers/IconListItemRenderer.mxml
> @@ -47,7 +47,7 @@ limitations under the License.
> <js:ItemRendererDataBinding />
> </j:beads>
>
> - <js:FontIcon text="{iconList.icon}" material="true" visible="{iconList.icon != null}" click="clickCloseButton()"/>
> + <js:FontIcon text="{iconList.icon}" material="true" visible="{iconList && iconList.icon != null}" click="clickCloseButton()"/>
>
> <html:Span text="{iconList.label}"/>
>
> diff --git a/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml b/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
> index 7cf6f77..84e6bf0 100644
> --- a/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
> +++ b/examples/royale/JewelExample/src/main/royale/itemRenderers/NavigationIconLinkItemRenderer.mxml
> @@ -39,7 +39,7 @@ limitations under the License.
> <js:ItemRendererDataBinding />
> </j:beads>
>
> - <js:FontIcon text="{navlink.icon}" material="true" visible="{navlink.icon != null}"/>
> + <js:FontIcon text="{navlink.icon}" material="true" visible="{navlink && navlink.icon != null}"/>
>
> <html:Span text="{navlink.label}"/>
>
>
>
>