You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2022/04/03 15:23:00 UTC
[jira] [Resolved] (HBASE-26919) Rewrite the counting rows part in TestFromClientSide4
[ https://issues.apache.org/jira/browse/HBASE-26919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Duo Zhang resolved HBASE-26919.
-------------------------------
Fix Version/s: 2.5.0
3.0.0-alpha-3
2.4.12
Hadoop Flags: Reviewed
Resolution: Fixed
Pushed to branch-2.4+.
Thanks [~Xiaolin Ha] for reviewing.
> Rewrite the counting rows part in TestFromClientSide4
> -----------------------------------------------------
>
> Key: HBASE-26919
> URL: https://issues.apache.org/jira/browse/HBASE-26919
> Project: HBase
> Issue Type: Sub-task
> Components: test
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.12
>
>
> Now we add an annotation to the variable declaration in the for loop, it will lead the following result after formatting
> {code}
> for (@SuppressWarnings("unused")
> Result row : scanner) {
> nbRows++;
> }
> {code}
> It looks really strange and checkstyle also reports indentation error.
> Let's just rewrite it an avoiding using annotation in this way, I do not know what is a better format for this scenario.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)