You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/04 07:28:26 UTC
[GitHub] [iotdb] HTHou opened a new pull request #2771: Change the default max JVM heap size from 8GB to 64GB
HTHou opened a new pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771
## Description
This PR is changing the default Maximum JVM heap size setting from 8GB to 64GB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#issuecomment-791074424
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=VULNERABILITY)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=SECURITY_HOTSPOT) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=SECURITY_HOTSPOT)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=2771&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/100.png' alt='100.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2771&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2771&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2771&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=2771&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r588062405
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
- # calculate 1/4 ram and cap to 8192MB
+ # calculate 1/4 ram and cap to 65536MB
# pick the max
half_system_memory_in_mb=`expr $system_memory_in_mb / 2`
quarter_system_memory_in_mb=`expr $half_system_memory_in_mb / 2`
if [ "$half_system_memory_in_mb" -gt "1024" ]
then
half_system_memory_in_mb="1024"
fi
- if [ "$quarter_system_memory_in_mb" -gt "8192" ]
Review comment:
ok， good..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r588056504
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
- # calculate 1/4 ram and cap to 8192MB
+ # calculate 1/4 ram and cap to 65536MB
# pick the max
half_system_memory_in_mb=`expr $system_memory_in_mb / 2`
quarter_system_memory_in_mb=`expr $half_system_memory_in_mb / 2`
if [ "$half_system_memory_in_mb" -gt "1024" ]
then
half_system_memory_in_mb="1024"
fi
- if [ "$quarter_system_memory_in_mb" -gt "8192" ]
Review comment:
https://github.com/apache/iotdb/blob/dc67d245740fd13b46fca4d95a33419b979405a2/server/src/assembly/resources/conf/iotdb-env.sh#L175-L180
We already have it. If users like to change it, just uncomment this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r588056504
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
- # calculate 1/4 ram and cap to 8192MB
+ # calculate 1/4 ram and cap to 65536MB
# pick the max
half_system_memory_in_mb=`expr $system_memory_in_mb / 2`
quarter_system_memory_in_mb=`expr $half_system_memory_in_mb / 2`
if [ "$half_system_memory_in_mb" -gt "1024" ]
then
half_system_memory_in_mb="1024"
fi
- if [ "$quarter_system_memory_in_mb" -gt "8192" ]
Review comment:
https://github.com/apache/iotdb/blob/dc67d245740fd13b46fca4d95a33419b979405a2/server/src/assembly/resources/conf/iotdb-env.sh#L175-L80
We already have it. I users like to change it, just uncomment this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r588056504
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
- # calculate 1/4 ram and cap to 8192MB
+ # calculate 1/4 ram and cap to 65536MB
# pick the max
half_system_memory_in_mb=`expr $system_memory_in_mb / 2`
quarter_system_memory_in_mb=`expr $half_system_memory_in_mb / 2`
if [ "$half_system_memory_in_mb" -gt "1024" ]
then
half_system_memory_in_mb="1024"
fi
- if [ "$quarter_system_memory_in_mb" -gt "8192" ]
Review comment:
https://github.com/apache/iotdb/blob/dc67d245740fd13b46fca4d95a33419b979405a2/server/src/assembly/resources/conf/iotdb-env.sh#L175-L180
We already have it. I users like to change it, just uncomment this line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] samperson1997 commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
samperson1997 commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r587227022
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
Review comment:
Should this be changed?
```suggestion
# calculate 1/2 ram and cap to 8192MB
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #2771: Change the default max JVM heap size from 8GB to 64GB
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #2771:
URL: https://github.com/apache/iotdb/pull/2771#discussion_r587955398
##########
File path: server/src/assembly/resources/conf/iotdb-env.sh
##########
@@ -66,19 +66,19 @@ calculate_heap_sizes()
fi
# set max heap size based on the following
- # max(min(1/2 ram, 1024MB), min(1/4 ram, 8GB))
+ # max(min(1/2 ram, 1024MB), min(1/4 ram, 64GB))
# calculate 1/2 ram and cap to 1024MB
- # calculate 1/4 ram and cap to 8192MB
+ # calculate 1/4 ram and cap to 65536MB
# pick the max
half_system_memory_in_mb=`expr $system_memory_in_mb / 2`
quarter_system_memory_in_mb=`expr $half_system_memory_in_mb / 2`
if [ "$half_system_memory_in_mb" -gt "1024" ]
then
half_system_memory_in_mb="1024"
fi
- if [ "$quarter_system_memory_in_mb" -gt "8192" ]
Review comment:
hi, haonan
We can extract a parameter and modify it to control the memory size.
This facilitates user modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org