You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "sgilmore10 (via GitHub)" <gi...@apache.org> on 2023/10/26 20:36:16 UTC
[PR] GH-38166: [MATLAB] [MATLAB] Improve tabular object display [arrow]
sgilmore10 opened a new pull request, #38482:
URL: https://github.com/apache/arrow/pull/38482
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Currently, the display for `arrow.tabular.RecordBatch` and `arrow.tabular.Table` are not very MATLAB-like.
### What changes are included in this PR?
1. Updated the display of both `arrow.tabular.Table` and `arrow.tabular.RecordBatch`.
2. Added a new utility function `arrow.internal.display.boldFontIfPossible`
3. Renamed `arrow.array.internal.display.pluralizeStringIfNeeded` to `arrow.internal.display.pluralizeStringIfNeeded`
4. Renamed `arrow.tabular.internal.displaySchema` to `arrow.tabular.internal.display.getSchemaString`.
**Example RecordBatch Display**
```matlab
>> t = table(1, false, datetime(2023, 1, 1), VariableNames=["Number", "Logical", "Date"]);
>> rb = arrow.recordBatch(t)
rb =
Arrow RecordBatch with 1 row and 3 columns:
Schema:
Number: Float64 | Logical: Boolean | Date: Timestamp
First Row:
1 | false | 2023-01-01 00:00:00.000000
```
**Example Table Display**
```matlab
>> t = table(1, false, datetime(2023, 1, 1), VariableNames=["Number", "Logical", "Date"]);
>> arrowTable = arrow.table(t)
arrowTable =
Arrow Table with 1 row and 3 columns:
Schema:
Number: Float64 | Logical: Boolean | Date: Timestamp
First Row:
1 | false | 2023-01-01 00:00:00.000000
```
### Are these changes tested?
Yes, I added a new test class in `matlab/test/arrow/tabular` called `tTabularDisplay.m`.
### Are there any user-facing changes?
Yes. Users will now see the new `Table`/`RecordBatch` display
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38166: [MATLAB] Improve tabular object display [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #38482:
URL: https://github.com/apache/arrow/pull/38482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38166: [MATLAB] Improve tabular object display [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38482:
URL: https://github.com/apache/arrow/pull/38482#issuecomment-1783063043
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38166: [MATLAB] Improve tabular object display [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38482:
URL: https://github.com/apache/arrow/pull/38482#issuecomment-1783444136
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 547b2406d71bf9ad14e2bcc7064c6923165dd737.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/18134270090) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38166: [MATLAB] [MATLAB] Improve tabular object display [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38482:
URL: https://github.com/apache/arrow/pull/38482#issuecomment-1781860474
:warning: GitHub issue #38166 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org