You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/06 14:28:23 UTC

[GitHub] [pulsar] freeznet commented on pull request #9124: Issue #9123 Go Functions

freeznet commented on pull request #9124:
URL: https://github.com/apache/pulsar/pull/9124#issuecomment-755329852


   @flowchartsman @sijie I have some findings related to #8761. 
   
   Currently go functions get `KeyBasedBatchBuilder` support with #8761, but the `batchBuilderType` is not exposed as an individual argument in `pulsar-function-go/conf/conf.go` https://github.com/apache/pulsar/blob/master/pulsar-function-go/conf/conf.go, so user cannot pass `batchBuilderType` to function, and `batchBuilder` is not usable. Additional, `ProducerSpec` from `SinkSpec` are not initialized  properly here: https://github.com/apache/pulsar/blob/master/pulsar-function-go/pf/instanceConf.go#L87-L90, and this will lead to #9123, user will get nil exception when access to `instanceConf.funcDetails.Sink.ProducerSpec`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org