You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jason Gustafson (JIRA)" <ji...@apache.org> on 2016/10/21 21:41:58 UTC

[jira] [Resolved] (KAFKA-4296) LogCleaner CleanerStats swap logic seems incorrect

     [ https://issues.apache.org/jira/browse/KAFKA-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gustafson resolved KAFKA-4296.
------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 0.10.1.1)
                   0.10.2.0

Issue resolved by pull request 2016
[https://github.com/apache/kafka/pull/2016]

> LogCleaner CleanerStats swap logic seems incorrect
> --------------------------------------------------
>
>                 Key: KAFKA-4296
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4296
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Jason Gustafson
>             Fix For: 0.10.2.0
>
>
> In LogCleaner, we keep track of two instances of the {{CleanerStats}} object in a tuple object. One instance is intended to keep track the stats for the last cycle while the other is for the current cycle. The idea is to swap them after each cleaning cycle, but the current logic does not actually mutate the existing tuple, which means that we always clear the same instance of {{CleanerStats}} after each cleaning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)