You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/01 14:53:07 UTC

[GitHub] [spark] cloud-fan edited a comment on pull request #31675: [SPARK-34560][SQL] Generate unique output attributes in the `SHOW TABLES` logical node

cloud-fan edited a comment on pull request #31675:
URL: https://github.com/apache/spark/pull/31675#issuecomment-788009085


   The change LGTM, but I'm wondering if we need to add a self-join test for every command that has output.
   
   Shall we simply make this fix for all the existing commands that have `output` (should be less than 5) in the constructor parameter  without tests as the issue is so obvious?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org