You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/09/09 15:37:56 UTC
[GitHub] [ignite] nizhikov commented on a change in pull request #6845:
IGNITE-12145: Monitoring list engine.
nizhikov commented on a change in pull request #6845: IGNITE-12145: Monitoring list engine.
URL: https://github.com/apache/ignite/pull/6845#discussion_r322312751
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClusterCachesInfo.java
##########
@@ -2514,7 +2572,7 @@ public void removeRestartingCaches() {
if (o1.cacheType().userCache() ^ o2.cacheType().userCache())
return o2.cacheType().userCache() ? -1 : 1;
- return o1.cacheId().compareTo(o2.cacheId());
+ return o1.cacheId() - o2.cacheId();
Review comment:
It's better to use primitives in `MonitoringRow` for the sake of speed.
Replaced with `Integer.compare(o1.cacheId(), o2.cacheId())`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services