[GitHub] [pulsar] devinbost opened a new pull request #6164: [Issue 6137] (WIP) Fix flaky tests

[GitBox <gi...@apache.org>]

devinbost opened a new pull request #6164: [Issue 6137] (WIP) Fix flaky tests
URL: https://github.com/apache/pulsar/pull/6164
 
 
   Fixes #6137 
   
   ### Motivation
   
   There are many unstable tests that pass locally but fail when run by Github Actions CI or Jenkins. 
   This drastically slows down development and prevents working code from being merged into master. 
   It appears that many of the unstable tests are associated with Thread.sleep or other timing issues. 
   Use of Thread.sleep is an antipattern in tests due to the associated stability issues. 
   This PR attempts to replace the usage of Thread.sleep with an asynchronous approach that will reduce some of the associated issues.
   
   ### Modifications
   
   Added Awaitility library and started refactoring shared test methods that use Thread.sleep.
   
   ### Verifying this change
   
   All existing tests should pass (unless this unearths other issues that will need to be addressed). 
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes, Awaitility)
     - Anything that affects deployment: (yes, affects tests)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] devinbost commented on issue #6164: [Issue 6137] (WIP) Fix flaky tests

[GitBox <gi...@apache.org>]

devinbost commented on issue #6164: [Issue 6137] (WIP) Fix flaky tests
URL: https://github.com/apache/pulsar/pull/6164#issuecomment-580066898
 
 
   Sorry, this PR was not intended to also include the Go features. I'll get that removed from the PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services