[GitHub] [lucene-solr] moshebla commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates

[GitBox <gi...@apache.org>]

moshebla commented on a change in pull request #647: SOLR-12638: Added docs in the ref-guide for nested atomic updates
URL: https://github.com/apache/lucene-solr/pull/647#discussion_r279198791
 
 

 ##########
 File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc
 ##########
 @@ -51,6 +51,13 @@ With the exception of in-place updates, the whole block must be updated or delet
   Consequently, the field need not be defined in the schema and probably shouldn't be as it would be confusing.
   There is no child document field type, at least not yet.
 
+[NOTE]
 
 Review comment:
   > /home/internet/Projects/lucene-solr/solr/package/solr-7.7.2-SNAPSHOT.tgz
   
   Currently we only throw an error if the wrong route param was supplied when updating a non root doc.
   Should we throw an error when no _route_ param is supplied?
   I could work on that if it is deemed necessary.
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org