[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4866: Removing segment generation config from RecordReader interface

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4866: Removing segment generation config from RecordReader interface
URL: https://github.com/apache/incubator-pinot/pull/4866#discussion_r351414770
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReader.java
 ##########
 @@ -34,10 +34,16 @@
 public interface RecordReader extends Closeable {
 
   /**
-   * Initializes the record reader when needed
+   * initializing recordreader with inputpath, schema and recordreader config. <br/>
+   * The implementation can chose to ignore one or more of these parameters and handle null gracefully <br/>
+   *
+   * @param inputPath absolute path to the file/directory
+   * @param schema Pinot Schema associated with the table
+   * @param recordReaderConfig config for the reader specific to the format. e.g. delimiter for csv format etc
+   * @throws Exception if the arguments are invalid
    */
-  void init(SegmentGeneratorConfig segmentGeneratorConfig)
-      throws IOException;
+  void init(@Nullable String inputPath, @Nullable Schema schema, @Nullable RecordReaderConfig recordReaderConfig)
 
 Review comment:
   Why not move input path and schema into RecordReaderConfig? That way, everything that the record reader needs is there in the config.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org