[GitHub] [skywalking] wu-sheng commented on a change in pull request #5605: Replace getClass() with instanceOf()

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #5605:
URL: https://github.com/apache/skywalking/pull/5605#discussion_r498075707



##########
File path: apm-application-toolkit/apm-toolkit-meter/src/main/java/org/apache/skywalking/apm/toolkit/meter/MeterId.java
##########
@@ -64,7 +64,7 @@ public MeterId copyTo(String name, MeterType type) {
     @Override
     public boolean equals(Object o) {
         if (this == o) return true;
-        if (o == null || getClass() != o.getClass()) return false;
+        if (o == null || !(o instanceof MeterId)) return false;

Review comment:
       This is how IDE(IntelliJ) generated. I don't think this is an issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org