You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2024/08/13 07:43:15 UTC

[Bug 8251] Building requires Perl Critic

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8251

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Sidney Markowitz <si...@sidney.com> ---
I removed the requirement in Makefile.PL. I fixed up the test so it not only
skips all tests if Perl::Critic is not installed, if it is installed it
silently skips the use of any not-installed Policy modules that are not bundled
with Perl::Critic. This commit also removes a line from Makefile.PL that was
included for debugging logging purposes and inadvertently committed to trunk.

If you do have Perl::Critic installed, the test will still be run. I'm working
on a better setup for release-only or perhaps developer-only tests, and I'll
put t/perlcritic.t in that category when I do it.

% svn ci -m "bug 8251 - make Perl::Critic an optional module for testing"
Makefile.PL t/perlcritic.pl 
Sending        Makefile.PL
Sending        t/perlcritic.pl
Transmitting file data ..done
Committing transaction...
Committed revision 1919846.

-- 
You are receiving this mail because:
You are the assignee for the bug.