[GitHub] [superset] john-bodley commented on a diff in pull request #24129: chore: Bump prophet

["john-bodley (via GitHub)" <gi...@apache.org>]

john-bodley commented on code in PR #24129:
URL: https://github.com/apache/superset/pull/24129#discussion_r1199243791


##########
superset/utils/pandas_postprocessing/prophet.py:
##########
@@ -134,7 +135,11 @@ def prophet(  # pylint: disable=too-many-arguments
         raise InvalidPostProcessingError(_("DataFrame include at least one series"))
 
     target_df = DataFrame()
-    for column in [column for column in df.columns if column != index]:
+    for column in [

Review Comment:
   @villebro I would love your input on this as I'm somewhat perplexed as to how this was working. After reenabling the tests it seemed to be trying to fit non-numerical columns within the `pd.DataFrame`. I couldn't find any options where we explicitly define which columns to produce a forecast for.
   
   The original logic I had was for determining numeric columns was,
   
   ```python
   df.select_dtypes(include=np.number).columns
   ```
   
   however the MySQL tests were failing because it seems like some of the numeric columns where of type `object` which is typically used to encode strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org