You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2024/03/12 14:01:14 UTC
[PR] chore(ci): fix wheel builds [arrow-adbc]
lidavidm opened a new pull request, #1612:
URL: https://github.com/apache/arrow-adbc/pull/1612
- Update versions to match upstream
- Add 3.8 support since upstream uses 3.8 as the base
- Adjust CI to test both 3.8 and 3.12
Fixes #1610.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): fix wheel builds [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #1612:
URL: https://github.com/apache/arrow-adbc/pull/1612#discussion_r1522104405
##########
.github/workflows/packaging.yml:
##########
@@ -544,16 +544,46 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- - name: Test wheel
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
+ env PYTHON=3.8 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
Review Comment:
```suggestion
- name: Test wheel 3.9
```
##########
.github/workflows/packaging.yml:
##########
@@ -544,16 +544,46 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- - name: Test wheel
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
+ env PYTHON=3.8 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
env:
ARCH: ${{ matrix.arch }}
MANYLINUX: ${{ matrix.manylinux_version }}
run: |
pushd adbc
env PYTHON=3.9 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
env PYTHON=3.10 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
env PYTHON=3.11 docker compose run python-wheel-manylinux-test
+ - name: Test wheel 3.8
Review Comment:
```suggestion
- name: Test wheel 3.12
```
##########
.github/workflows/packaging.yml:
##########
@@ -544,16 +544,46 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- - name: Test wheel
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
+ env PYTHON=3.8 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
env:
ARCH: ${{ matrix.arch }}
MANYLINUX: ${{ matrix.manylinux_version }}
run: |
pushd adbc
env PYTHON=3.9 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
Review Comment:
```suggestion
- name: Test wheel 3.10
```
##########
.github/workflows/packaging.yml:
##########
@@ -544,16 +544,46 @@ jobs:
adbc/python/adbc_driver_sqlite/repaired_wheels/*.whl
adbc/python/adbc_driver_snowflake/repaired_wheels/*.whl
- - name: Test wheel
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
+ env PYTHON=3.8 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
env:
ARCH: ${{ matrix.arch }}
MANYLINUX: ${{ matrix.manylinux_version }}
run: |
pushd adbc
env PYTHON=3.9 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
+ env:
+ ARCH: ${{ matrix.arch }}
+ MANYLINUX: ${{ matrix.manylinux_version }}
+ run: |
+ pushd adbc
env PYTHON=3.10 docker compose run python-wheel-manylinux-test
+
+ - name: Test wheel 3.8
Review Comment:
```suggestion
- name: Test wheel 3.11
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): fix wheel builds [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1612:
URL: https://github.com/apache/arrow-adbc/pull/1612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): fix wheel builds [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1612:
URL: https://github.com/apache/arrow-adbc/pull/1612#issuecomment-1994219514
When I poked it locally, cibuildwheel was fine but the steps after that weren't
3.8 looks to go out of support soon-ish anyways, yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): fix wheel builds [arrow-adbc]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #1612:
URL: https://github.com/apache/arrow-adbc/pull/1612#issuecomment-1993753929
FWIW you could also have instructed cibuildwheel to not build a wheel for 3.8 (eg through env variable like `CIBW_BUILD: cp38-*`).
(we should drop support for Python 3.8 upstream as well IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org