[GitHub] [spark] Fokko commented on a change in pull request #29122: [SPARK-32320][PYSPARK] Remove mutable default arguments

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #29122:
URL: https://github.com/apache/spark/pull/29122#discussion_r508858955



##########
File path: python/pyspark/ml/regression.py
##########
@@ -1654,7 +1656,7 @@ class _AFTSurvivalRegressionParams(_PredictorParams, HasMaxIter, HasTol, HasFitI
     def __init__(self, *args):
         super(_AFTSurvivalRegressionParams, self).__init__(*args)
         self._setDefault(censorCol="censor",
-                         quantileProbabilities=[0.01, 0.05, 0.1, 0.25, 0.5, 0.75, 0.9, 0.95, 0.99],
+                         quantileProbabilities=DEFAULT_QUANTILE_PROBABILITIES,

Review comment:
       Yes, you are correct. The code isn't being used. I've removed the default argument.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org