[GitHub] [incubator-nuttx] patacongo commented on pull request #1149: tools/: Hook incdir.c into build system.

[GitBox <gi...@apache.org>]

patacongo commented on pull request #1149:
URL: https://github.com/apache/incubator-nuttx/pull/1149#issuecomment-636243714


   > Let's get this one in and see if there is any issue with the nightly build.
   
   @xiaoxiang781216 @yamt Please continue provide review comments.  I will address all review comments after the merge with another PR.
   
   I am very pleased with the result of this change.  I am not getting 46 seconds builds under Cygwin with -j.  I have never had such great performance under cygwin before.
   
   @Ouss4 also noted some build improvements even with Linux which I was not expecting.
   
   I am thinking we should convert any other scripts to .c files if we think they are performance bottle necks.  Not only do C files improve performance, but they can also support portability to native mode builds (I suspect that incdir.c does not have enough in place to support the native build, that is unverified).  But, for example, configure.c does support Windows native builds.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org