You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by gv...@apache.org on 2017/03/16 09:28:51 UTC
[08/14] incubator-carbondata git commit: Handled review comments
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/6b3b16c5/processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java b/processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
index 6f6637a..35b7989 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/newflow/DataLoadProcessBuilder.java
@@ -147,20 +147,18 @@ public final class DataLoadProcessBuilder {
// First add dictionary and non dictionary dimensions because these are part of mdk key.
// And then add complex data types and measures.
for (CarbonColumn column : dimensions) {
- if (!column.isInvisible()) {
- DataField dataField = new DataField(column);
- dataField.setDateFormat(dateFormatMap.get(column.getColName()));
- if (column.isComplex()) {
- complexDataFields.add(dataField);
- } else {
- dataFields.add(dataField);
- }
+ DataField dataField = new DataField(column);
+ dataField.setDateFormat(dateFormatMap.get(column.getColName()));
+ if (column.isComplex()) {
+ complexDataFields.add(dataField);
+ } else {
+ dataFields.add(dataField);
}
}
dataFields.addAll(complexDataFields);
for (CarbonColumn column : measures) {
// This dummy measure is added when no measure was present. We no need to load it.
- if (!column.isInvisible() && !(column.getColName().equals("default_dummy_measure"))) {
+ if (!(column.getColName().equals("default_dummy_measure"))) {
dataFields.add(new DataField(column));
}
}
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/6b3b16c5/processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
index eff5fca..bde8215 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
@@ -402,15 +402,11 @@ public final class CarbonDataProcessorUtil {
List<CarbonDimension> dimensions =
schema.getCarbonTable().getDimensionByTableName(factTableName);
for (CarbonDimension dimension : dimensions) {
- if (!dimension.isInvisible()) {
- columnNames.add(dimension.getColName());
- }
+ columnNames.add(dimension.getColName());
}
List<CarbonMeasure> measures = schema.getCarbonTable().getMeasureByTableName(factTableName);
for (CarbonMeasure msr : measures) {
- if (!msr.getColumnSchema().isInvisible()) {
- columnNames.add(msr.getColName());
- }
+ columnNames.add(msr.getColName());
}
} else {
List<CarbonDimension> dimensions = schema.getCarbonTable().getDimensionByTableName(tableName);