You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by xueyumusic <gi...@git.apache.org> on 2018/07/04 06:46:24 UTC

[GitHub] flink issue #6188: [FLINK-6846][Table API] add timestampAdd tableApi

Github user xueyumusic commented on the issue:

    https://github.com/apache/flink/pull/6188
  
    @twalthr I looked around and realized that current `+` expression could support TimeInterval (TimePoint) addition, thus the timestampAdd api is duplicated and seems have no necessary. 
    
    so I only made these changes:
    1. add `1.week` expression
    2. modify `quarter` as `1.quarter` 
    3. modify Extract to support extracting QUARTER and WEEK, as suggested and verified by @walterddr 
    
    Please have a review, @twalthr @fhueske @walterddr @hequn8128  thanks for all of you,


---