You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/26 05:39:07 UTC
[GitHub] [spark] sarutak opened a new pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
sarutak opened a new pull request #32344:
URL: https://github.com/apache/spark/pull/32344
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR proposes to introduce a new JDBC option `refreshKrb5Config` which allows to reflect the change of `krb5.conf`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
In the current master, JDBC datasources can't accept `refreshKrb5Config` which is defined in `Krb5LoginModule`.
So even if we change the `krb5.conf` after establishing a connection, the change will not be reflected.
The similar issue happens when we run multiple `*KrbIntegrationSuites` at the same time.
`MiniKDC` starts and stop every KerberosIntegrationSuite and different port number is recorded to `krb5.conf`.
Due to `SecureConnectionProvider.JDBCConfiguration` doesn't take `refreshKrb5Config`, KerberosIntegrationSuites except the first running one see the wrong port so those suites fail.
You can easily confirm with the following command.
```
build/sbt -Phive Phive-thriftserver -Pdocker-integration-tests "testOnly org.apache.spark.sql.jdbc.*KrbIntegrationSuite"
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Users can set `refreshKrb5Config` to refresh krb5 relevant configuration.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827263119
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32344:
URL: https://github.com/apache/spark/pull/32344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on a change in pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #32344:
URL: https://github.com/apache/spark/pull/32344#discussion_r620750775
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerKrbJDBCIntegrationSuite.scala
##########
@@ -160,4 +161,53 @@ abstract class DockerKrbJDBCIntegrationSuite extends DockerJDBCIntegrationSuite
assert(rows(0).getString(0) === "foo")
assert(rows(0).getString(1) === "bar")
}
+
+ test("SPARK-35226: JDBCOption should accept refreshKrb5Config parameter") {
+ // This makes sure Spark must do authentication
+ Configuration.setConfiguration(null)
+ withTempDir { dir =>
+ val dummyKrb5Conf = File.createTempFile("dummy", "krb5.conf", dir)
+ val origKrb5Conf = sys.props("java.security.krb5.conf")
Review comment:
Thank you. I've updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827242970
**[Test build #137974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137974/testReport)** for PR 32344 at commit [`5df750d`](https://github.com/apache/spark/commit/5df750dcc364ea866aca7b2b9e3e921bd470b5f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827242970
**[Test build #137974 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137974/testReport)** for PR 32344 at commit [`5df750d`](https://github.com/apache/spark/commit/5df750dcc364ea866aca7b2b9e3e921bd470b5f0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826612528
**[Test build #137934 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137934/testReport)** for PR 32344 at commit [`1a2c472`](https://github.com/apache/spark/commit/1a2c4720d02480a2d75337b6591d612943774d2d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828260492
**[Test build #138024 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138024/testReport)** for PR 32344 at commit [`600598e`](https://github.com/apache/spark/commit/600598e9182c72b0eb5597bcafb9dbaca7180424).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826519605
**[Test build #137934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137934/testReport)** for PR 32344 at commit [`1a2c472`](https://github.com/apache/spark/commit/1a2c4720d02480a2d75337b6591d612943774d2d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826544923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42456/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827267133
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826544896
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42456/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826544923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42456/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827232716
Thank you for update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828262289
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138024/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827306943
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137974/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826621940
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828176817
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827267133
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828158392
**[Test build #138024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138024/testReport)** for PR 32344 at commit [`600598e`](https://github.com/apache/spark/commit/600598e9182c72b0eb5597bcafb9dbaca7180424).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32344:
URL: https://github.com/apache/spark/pull/32344#discussion_r620351073
##########
File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerKrbJDBCIntegrationSuite.scala
##########
@@ -160,4 +161,53 @@ abstract class DockerKrbJDBCIntegrationSuite extends DockerJDBCIntegrationSuite
assert(rows(0).getString(0) === "foo")
assert(rows(0).getString(1) === "bar")
}
+
+ test("SPARK-35226: JDBCOption should accept refreshKrb5Config parameter") {
+ // This makes sure Spark must do authentication
+ Configuration.setConfiguration(null)
+ withTempDir { dir =>
+ val dummyKrb5Conf = File.createTempFile("dummy", "krb5.conf", dir)
+ val origKrb5Conf = sys.props("java.security.krb5.conf")
Review comment:
Shall we use the pre-defined `KRB5_CONF_PROP` instead of `java.security.krb5.conf`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827259111
cc @gaborgsomogyi FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828158392
**[Test build #138024 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138024/testReport)** for PR 32344 at commit [`600598e`](https://github.com/apache/spark/commit/600598e9182c72b0eb5597bcafb9dbaca7180424).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827928668
@gaborgsomogyi Thanks for your suggestion. So, it seems better to note in [the doc](http://spark.apache.org/docs/latest/sql-data-sources-jdbc.html) about the possibility of race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827306300
**[Test build #137974 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137974/testReport)** for PR 32344 at commit [`5df750d`](https://github.com/apache/spark/commit/5df750dcc364ea866aca7b2b9e3e921bd470b5f0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827928668
@gaborgsomogyi Thanks for your suggestion. So, it seems to better to note in [the doc](http://spark.apache.org/docs/latest/sql-data-sources-jdbc.html) about the possibility of race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gaborgsomogyi commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827417095
@HyukjinKwon thanks for pinging me.
I've had a look at the change and I think it looks good but can introduce a race. Let me share the use-case:
* User sets `refreshKrb5Config` flag with `Security context 1`
* User uses a JDBC connection provider
* User modifies `krb5.conf` but JVM not yet realized that it must be reloaded
* Spark authenticates [here](https://github.com/apache/spark/blob/55dea2d937a375d9929937ee66aa9bfed158b883/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala#L68) successfully
* JVM loads the `Security context 2` from the modified `krb5.conf`
* Spark restores the previously saved `Security context 1` [here](https://github.com/apache/spark/blob/55dea2d937a375d9929937ee66aa9bfed158b883/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/ConnectionProvider.scala#L71)
* The modified `krb5.conf` content just gone
This is just one example, the second one is when config update happens between security context modification and authentication. Such case JDBC authentication will fail temporarily.
I'm not against to add this but I think it's a must to mention somewhere that setting this flag can cause severe issues on running workloads. Seems like the doc change is missing, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828179150
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828262289
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138024/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827306943
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137974/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826519605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828183692
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826544923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42456/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826519605
**[Test build #137934 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137934/testReport)** for PR 32344 at commit [`1a2c472`](https://github.com/apache/spark/commit/1a2c4720d02480a2d75337b6591d612943774d2d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-827264569
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42494/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828938944
Merged to `master` and `branch-3.1`. Thanks all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] Support refreshKrb5Config option in JDBC datasources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-828183692
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826544923
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42456/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32344: [SPARK-35226][SQL] JDBC datasources should accept refreshKrb5Config parameter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32344:
URL: https://github.com/apache/spark/pull/32344#issuecomment-826621940
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137934/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org