You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/14 17:14:13 UTC

[GitHub] [arrow] jhorstmann commented on a change in pull request #8662: ARROW-9911: [Rust][DataFusion] SELECT with no FROM clause should produce a single row of output

jhorstmann commented on a change in pull request #8662:
URL: https://github.com/apache/arrow/pull/8662#discussion_r523441350



##########
File path: rust/datafusion/src/physical_plan/projection.rs
##########
@@ -114,14 +117,33 @@ impl ExecutionPlan for ProjectionExec {
     }
 
     async fn execute(&self, partition: usize) -> Result<SendableRecordBatchStream> {
+        let input = if self.input.as_any().downcast_ref::<EmptyExec>().is_some() {

Review comment:
       Maybe a separate `OneRowExec` and corresponding logical `OneRowRelation` would be even cleaner, but that is probably nitpicking.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org