You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/08/23 21:46:42 UTC

[jira] [Created] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Colin Patrick McCabe created HDFS-3849:
------------------------------------------

             Summary: When re-loading the FSImage, we should clear the existing genStamp and leases.
                 Key: HDFS-3849
                 URL: https://issues.apache.org/jira/browse/HDFS-3849
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 2.2.0-alpha
            Reporter: Colin Patrick McCabe
            Assignee: Colin Patrick McCabe
            Priority: Minor


When re-loading the FSImage, we should clear the existing genStamp and leases.

This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-3849:
---------------------------------------

    Attachment: HDFS-3849.002.patch

add another test which invokes the 2NN checkpointing code directly
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-3849:
------------------------------

    Priority: Critical  (was: Minor)

We saw a case where this caused a 2NN to stop checkpointing successfully. Bumping to critical priority.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444074#comment-13444074 ] 

Hudson commented on HDFS-3849:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1180 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1180/])
    HDFS-3849. When re-loading the FSImage, we should clear the existing genStamp and leases. Contributed by Colin Patrick McCabe. (Revision 1378364)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378364
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java

                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443624#comment-13443624 ] 

Hudson commented on HDFS-3849:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2682 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2682/])
    HDFS-3849. When re-loading the FSImage, we should clear the existing genStamp and leases. Contributed by Colin Patrick McCabe. (Revision 1378364)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378364
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java

                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442799#comment-13442799 ] 

Hadoop QA commented on HDFS-3849:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542668/HDFS-3849.002.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestHftpDelegationToken

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3103//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3103//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3103//console

This message is automatically generated.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aaron T. Myers updated HDFS-3849:
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2.0-alpha
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I've just committed this to trunk and branch-2.

Thanks a lot for the contribution, Colin.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-3849:
---------------------------------------

    Attachment: HDFS-3849.003.patch

* don't set DT config
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-3849:
---------------------------------------

    Status: Patch Available  (was: Open)
    
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442839#comment-13442839 ] 

Colin Patrick McCabe commented on HDFS-3849:
--------------------------------------------

I confirmed that {{TestHftpDelegationToken}} fails before this patch is applied.  It's an unrelated failure.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443445#comment-13443445 ] 

Aaron T. Myers commented on HDFS-3849:
--------------------------------------

+1 pending Jenkins.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colin Patrick McCabe updated HDFS-3849:
---------------------------------------

    Attachment: HDFS-3849.001.patch
    
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443596#comment-13443596 ] 

Hudson commented on HDFS-3849:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2653 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2653/])
    HDFS-3849. When re-loading the FSImage, we should clear the existing genStamp and leases. Contributed by Colin Patrick McCabe. (Revision 1378364)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378364
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java

                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HDFS-3849.
-------------------------------

    
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.2-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.0.2-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442954#comment-13442954 ] 

Aaron T. Myers commented on HDFS-3849:
--------------------------------------

The latest patch looks almost perfect to me, and good test cases, Colin.

One small nit: there's no need for enabling the DT config in the new test case in TestCheckpoint. +1 once this is addressed.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444020#comment-13444020 ] 

Hudson commented on HDFS-3849:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1149 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1149/])
    HDFS-3849. When re-loading the FSImage, we should clear the existing genStamp and leases. Contributed by Colin Patrick McCabe. (Revision 1378364)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378364
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java

                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443598#comment-13443598 ] 

Hudson commented on HDFS-3849:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2716 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2716/])
    HDFS-3849. When re-loading the FSImage, we should clear the existing genStamp and leases. Contributed by Colin Patrick McCabe. (Revision 1378364)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378364
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/LeaseManager.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/SecondaryNameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSNamesystem.java

                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442808#comment-13442808 ] 

Hadoop QA commented on HDFS-3849:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542668/HDFS-3849.002.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestHftpDelegationToken

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3102//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3102//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3102//console

This message is automatically generated.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3849) When re-loading the FSImage, we should clear the existing genStamp and leases.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443541#comment-13443541 ] 

Hadoop QA commented on HDFS-3849:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542806/HDFS-3849.003.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestHftpDelegationToken

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3112//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3112//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3112//console

This message is automatically generated.
                
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-3849
>                 URL: https://issues.apache.org/jira/browse/HDFS-3849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.2.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Critical
>         Attachments: HDFS-3849.001.patch, HDFS-3849.002.patch, HDFS-3849.003.patch
>
>
> When re-loading the FSImage, we should clear the existing genStamp and leases.
> This is an issue in the 2NN, because it sometimes clears the existing FSImage and reloads a new one in order to get back in sync with the NN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira