You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/30 21:32:00 UTC
[jira] [Commented] (ZOOKEEPER-2915) Use "strict" conflict
management in ivy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273494#comment-16273494 ]
ASF GitHub Bot commented on ZOOKEEPER-2915:
-------------------------------------------
GitHub user afine opened a pull request:
https://github.com/apache/zookeeper/pull/426
ZOOKEEPER-2915: Use "strict" conflict management in ivy
Same as https://github.com/apache/zookeeper/pull/397 just targeting https://github.com/apache/zookeeper/pull/397
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2915_3.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/426.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #426
----
commit d6d79561c9658a007f8e57222fefbfe0645a29e0
Author: Abraham Fine <af...@apache.org>
Date: 2017-11-30T21:30:30Z
ZOOKEEPER-2915: Use "strict" conflict management in ivy
----
> Use "strict" conflict management in ivy
> ---------------------------------------
>
> Key: ZOOKEEPER-2915
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2915
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.11, 3.5.4, 3.6.0
> Reporter: Abraham Fine
> Assignee: Abraham Fine
>
> Currently it is very difficult to tell exactly which dependencies make it into the final classpath of zookeeper. We do not perform any conflict resolution between the test and default classpaths (this has resulted in strange behavior with the slf4j-log4j12 binding) and have no way of telling if a change to the dependencies has altered the transitive dependencies pulled down by the project.
> Our dependency list is relatively small so we should use "strict" conflict management (break the build when we try to pull two versions of the same dependency) so we can exercise maximum control over the classpath.
> Note: I also attempted to find a way to see if I could always prefer transitive dependencies from the default configuration over those pulled by the test configuration (to make sure that the zookeeper we test against has the same dependencies as the one we ship) but this appears to be impossible (or at least incredibly difficult) with ivy. Any opinions here would be greatly appreciated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)