You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lbownik (via GitHub)" <gi...@apache.org> on 2023/01/26 12:42:53 UTC
[GitHub] [netbeans] lbownik opened a new pull request, #5368: StringBuilder related performance improvements - no logic changes
lbownik opened a new pull request, #5368:
URL: https://github.com/apache/netbeans/pull/5368
fixed few "concatenation in append" issues
initialized String builders to larger size to mitigate internal realocations
removed one unnecessary StringBuilder creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net closed pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net closed pull request #5368: StringBuilder related performance improvements - no logic changes
URL: https://github.com/apache/netbeans/pull/5368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5368:
URL: https://github.com/apache/netbeans/pull/5368#issuecomment-1404965235
`JavaCodeTemplateProcessor.java:212: error: ')' expected`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lbownik commented on pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "lbownik (via GitHub)" <gi...@apache.org>.
lbownik commented on PR #5368:
URL: https://github.com/apache/netbeans/pull/5368#issuecomment-1405029542
> Please at least check things build and run before opening a PR. Thanks!
@neilcsmith-net You could have waited an hour before closing, I would fhave fixed it :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5368:
URL: https://github.com/apache/netbeans/pull/5368#issuecomment-1405016740
Please at least check things build and run before opening a PR. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] tbw777 commented on pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #5368:
URL: https://github.com/apache/netbeans/pull/5368#issuecomment-1404957916
I have a branch where append is fixed for 2000+ files. But I'm not allowed to make that kind of change anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #5368: StringBuilder related performance improvements - no logic changes
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #5368:
URL: https://github.com/apache/netbeans/pull/5368#issuecomment-1405282051
@lbownik and @tbw777
> But I'm not allowed to make that kind of changes anymore
This is nonsense. There is a small number of active reviewers. @BradWalker gives a pretty good advice here:
https://github.com/apache/netbeans/pull/5332#issuecomment-1399174804
If you did not already do so, I strongly advice you to subscribe to dev@netbeans.apache.org (https://netbeans.apache.org/community/mailing-lists.html#dev), where you can raise questions and read about current discussions.
I think it is worth reading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists