You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "suxiaogang223 (via GitHub)" <gi...@apache.org> on 2024/10/10 08:06:26 UTC
[PR] [charry-pick](branch3.0) support text hive [doris]
suxiaogang223 opened a new pull request, #41656:
URL: https://github.com/apache/doris/pull/41656
## Proposed changes
pick from master:
https://github.com/apache/doris/pull/40315
https://github.com/apache/doris/pull/40291
https://github.com/apache/doris/pull/40183
https://github.com/apache/doris/pull/38549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [charry-pick](branch3.0) support text hive [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41656:
URL: https://github.com/apache/doris/pull/41656#issuecomment-2404377503
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [charry-pick](branch3.0) support text hive [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #41656:
URL: https://github.com/apache/doris/pull/41656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [charry-pick](branch3.0) support text hive [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #41656:
URL: https://github.com/apache/doris/pull/41656#discussion_r1794938504
##########
be/src/util/block_compression.h:
##########
@@ -17,6 +17,7 @@
#pragma once
+#include <gen_cpp/PlanNodes_types.h>
Review Comment:
warning: 'gen_cpp/PlanNodes_types.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/PlanNodes_types.h>
^
```
##########
be/src/vec/exec/format/csv/csv_reader.cpp:
##########
@@ -174,6 +174,23 @@ void PlainCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>*
}
}
+void HiveCsvTextFieldSplitter::do_split(const Slice& line, std::vector<Slice>* splitted_values) {
Review Comment:
warning: method 'do_split' can be made const [readability-make-member-function-const]
be/src/vec/exec/format/csv/csv_reader.cpp:177:
```diff
- values) {
+ values) const {
```
##########
be/src/exec/decompressor.h:
##########
@@ -126,6 +137,25 @@ class Bzip2Decompressor : public Decompressor {
bz_stream _bz_strm;
};
+class ZstdDecompressor : public Decompressor {
+public:
+ ~ZstdDecompressor() override;
+
+ Status decompress(uint8_t* input, size_t input_len, size_t* input_bytes_read, uint8_t* output,
+ size_t output_max_len, size_t* decompressed_len, bool* stream_end,
+ size_t* more_input_bytes, size_t* more_output_bytes) override;
+
+ std::string debug_info() override;
+
+private:
+ friend class Decompressor;
+ ZstdDecompressor() : Decompressor(CompressType::ZSTD) {}
+ Status init() override;
+
+private:
Review Comment:
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/exec/decompressor.h:149:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [charry-pick](branch3.0) support text hive [doris]
Posted by "suxiaogang223 (via GitHub)" <gi...@apache.org>.
suxiaogang223 commented on PR #41656:
URL: https://github.com/apache/doris/pull/41656#issuecomment-2404387727
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org