You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "Otto Fowler (JIRA)" <ji...@apache.org> on 2019/07/27 14:53:00 UTC
[jira] [Created] (METRON-2195) Add defensive log level checks when
constructing logs is expensive
Otto Fowler created METRON-2195:
-----------------------------------
Summary: Add defensive log level checks when constructing logs is expensive
Key: METRON-2195
URL: https://issues.apache.org/jira/browse/METRON-2195
Project: Metron
Issue Type: Improvement
Reporter: Otto Fowler
There are instances where we log, and output strings for json objects and other things that are quite expensive.
These are done regardless of the log level being enabled and can increase performance significantly:
https://gist.github.com/mmiklavc/7fd6af13bfa0ca05d9b3f4e7806c8d77
https://github.com/apache/metron/blob/master/metron-platform/metron-writer/metron-writer-storm/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java#L127
We need to find places where this happens, and employ the best practice check for the log level being enabled ( best practice if your parameters or log message construction takes a lot of time ).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)