You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/10 09:08:32 UTC

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #948: Fix: make metadata report work without serviceDiscovery

codecov-io edited a comment on pull request #948:
URL: https://github.com/apache/dubbo-go/pull/948#issuecomment-748812294


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=h1) Report
   > Merging [#948](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=desc) (785e323) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/374a01a37d527067383664ee26088a870bbeaf5d?el=desc) (374a01a) will **increase** coverage by `0.32%`.
   > The diff coverage is `5.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/948/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #948      +/-   ##
   ===========================================
   + Coverage    59.59%   59.91%   +0.32%     
   ===========================================
     Files          261      260       -1     
     Lines        12903    12918      +15     
   ===========================================
   + Hits          7689     7740      +51     
   + Misses        4243     4217      -26     
   + Partials       971      961      -10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/metadata\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9zZXJ2aWNlLmdv) | `0.00% <0.00%> (ø)` | |
   | [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `28.92% <0.00%> (+0.92%)` | :arrow_up: |
   | [metadata/service/remote/service.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-bWV0YWRhdGEvc2VydmljZS9yZW1vdGUvc2VydmljZS5nbw==) | `32.95% <0.00%> (-6.78%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <33.33%> (ø)` | |
   | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `62.06% <33.33%> (+7.40%)` | :arrow_up: |
   | [protocol/dubbo/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
   | [remoting/getty/opentracing.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvb3BlbnRyYWNpbmcuZ28=) | `73.33% <0.00%> (-26.67%)` | :arrow_down: |
   | [cluster/router/tag/router\_rule.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvdGFnL3JvdXRlcl9ydWxlLmdv) | `77.27% <0.00%> (-12.21%)` | :arrow_down: |
   | [...nthesizer/rest/rest\_subscribed\_urls\_synthesizer.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zeW50aGVzaXplci9yZXN0L3Jlc3Rfc3Vic2NyaWJlZF91cmxzX3N5bnRoZXNpemVyLmdv) | `81.25% <0.00%> (-11.61%)` | :arrow_down: |
   | [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
   | ... and [46 more](https://codecov.io/gh/apache/dubbo-go/pull/948/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=footer). Last update [374a01a...c8fb3e9](https://codecov.io/gh/apache/dubbo-go/pull/948?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org