You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/05 16:22:37 UTC
[GitHub] [logging-log4j2] MouettE-SC opened a new pull request #682: Add environment variable arbiter
MouettE-SC opened a new pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682
This is a simple arbiter using environment variables functionnally based on the existing system property arbiter (on which I corrected some typos).
I tried to write unit tests for it but injecting environment variables in junit is not easy. I tried [system-rules](https://stefanbirkner.github.io/system-rules/index.html#EnvironmentVariables) but it didn't work so I did not include it in this PR. I tested the arbiter in my application and it seems to work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] Zhnz commented on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
Zhnz commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1064211903
Wouldn't be using a PluginFactory instead of a PluginBuilderFactory way shorter? I think that would be better. I implemented my own custom EnvironmentArbiter this way (because this one still isn't merged :P)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
MouettE-SC commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property ones with system-rules which does not work on my machine. That test structure is already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
MouettE-SC commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011391582
Let me know if there is anything I can do to help, like opening an issue on Jira, writing the documentation part or anything, I'll be happy to !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] MouettE-SC edited a comment on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
MouettE-SC edited a comment on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005973657
> Thanks for this. I should be able to create the unit tests for it.
Great ! I've added the tests I wrote, based on the current system property ones with system-rules which does not work on my machine. That way test structure is already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] rgoers commented on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
rgoers commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1005915855
Thanks for this. I should be able to create the unit tests for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] MouettE-SC commented on pull request #682: Add environment variable arbiter
Posted by GitBox <gi...@apache.org>.
MouettE-SC commented on pull request #682:
URL: https://github.com/apache/logging-log4j2/pull/682#issuecomment-1011384397
Sorry, forgot to comment that I was able to create working tests for the environment arbiter using system-lambda. Hope you'll find them satisfying !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org