You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "stevedlawrence (via GitHub)" <gi...@apache.org> on 2023/06/08 11:43:43 UTC
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #305: Add semantic highlighting for XPath expressions
stevedlawrence commented on PR #305:
URL: https://github.com/apache/daffodil-vscode/pull/305#issuecomment-1582431180
The MIT license does allow modifications to be licensed under different terms, you really just need to include the copyright header and MIT license. So you could in theory license your changes using ALv2. However, it adds a extra complexity, since you need to make it clear which parts are MIT and which are ALv2. And it doesn't really gain much having some parts be ALv2. It's recommended, and fine with the ASF, to license minor modifications under the original license.
In fact, this page has some information about this exact thing in "Treatment of Third-Party Works": https://www.apache.org/legal/src-headers.html, and says exactly that in bullet 4:
> 4. Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience.
If the changes are "major" then we probably need to have a discussion to determine if mixing licenses is appropriate, and "major" vs "minor" is pretty subjective, but based on your description it sounds like they are pretty clearly minor changes.
So I'd just keep everything under the same MIT license terms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org