[maven-dependency-plugin] 06/08: Perform transformation to artifact keys just once

[rf...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

rfscholte pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-dependency-plugin.git

commit 01decd08e7f067592e25570f8f480dd2af1dc782
Author: Maarten Mulders <ma...@infosupport.com>
AuthorDate: Fri Sep 6 15:32:11 2019 +0200

    Perform transformation to artifact keys just once
---
 .../resolvers/ExcludeReactorProjectsArtifactFilter.java          | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsArtifactFilter.java b/src/main/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsArtifactFilter.java
index fbeda30..4c57ca5 100644
--- a/src/main/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsArtifactFilter.java
+++ b/src/main/java/org/apache/maven/plugins/dependency/resolvers/ExcludeReactorProjectsArtifactFilter.java
@@ -40,15 +40,15 @@ import java.util.Set;
 public class ExcludeReactorProjectsArtifactFilter extends AbstractArtifactsFilter
 {
     private final Log log;
-    private final Set<Artifact> reactorArtifacts;
+    private final Set<String> reactorArtifactKeys;
 
     public ExcludeReactorProjectsArtifactFilter( final List<MavenProject> reactorProjects, final Log log )
     {
         this.log = log;
-        this.reactorArtifacts = new HashSet<>( reactorProjects.size() );
+        this.reactorArtifactKeys = new HashSet<>( reactorProjects.size() );
         for ( final MavenProject project : reactorProjects )
         {
-            this.reactorArtifacts.add( project.getArtifact() );
+            this.reactorArtifactKeys.add( ArtifactUtils.key( project.getArtifact() ) );
         }
     }
 
@@ -79,9 +79,8 @@ public class ExcludeReactorProjectsArtifactFilter extends AbstractArtifactsFilte
 
     private boolean isArtifactInReactor( final Artifact artifact )
     {
-        for ( final Artifact reactorArtifact : reactorArtifacts )
+        for ( final String reactorArtifactKey : this.reactorArtifactKeys )
         {
-            final String reactorArtifactKey = ArtifactUtils.key( reactorArtifact );
             final String artifactKey = ArtifactUtils.key( artifact );
 
             // This check only includes GAV. Should we take a look at the types, too?