[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1242: [NETBEANS-2509] Bring back docker plugin support for unix sockets

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1242:  [NETBEANS-2509] Bring back docker plugin support for unix sockets
URL: https://github.com/apache/netbeans/pull/1242#discussion_r283942407
 
 

 ##########
 File path: ide/libs.c.kohlschutter.junixsocket/external/junixsocket-common-2.2.0-license.txt
 ##########
 @@ -0,0 +1,210 @@
+Name: junixsocket
+License: Apache-2.0
+OSR: 4300
+Description: junixsocket is a Java/JNI library that allows the use of Unix Domain Sockets (AF_UNIX sockets) from Java.
+Origin: https://github.com/kohlschutter/junixsocket/
+Version: 2.2.0
 
 Review comment:
   There is no need for three copies of the license file. Please remove two copies and rename the remaining copy to "junixsocket-license.txt". Add a new header line that references the three files:
   ```
   Files: junixsocket-common-2.2.0.jar, junixsocket-core-2.2.0.jar, junixsocket-native-common-2.2.0.jar
   ```
   
   What is more, the ALv2 requires to carry the NOTICE if the source package has one. In this case the original author failed to include it in his/her binaries, but we are good citizens of the ecosystem.
   
   Here is the notice file:
   https://github.com/kohlschutter/junixsocket/blob/master/NOTICE
   
   Please add a file "junixsocket-notice.txt", with the contents of the above referenced file. The contents of that file will be picked up by the build system and integrated into the final notice file of NetBeans.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists