You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Rui Wang <am...@apache.org> on 2021/12/21 01:27:01 UTC
[VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Hi all,
I have created a build for Apache Calcite 1.29.0, release
candidate 0.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
The commit to be voted upon:
https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
(revision 51667)
The hashes of the artifacts are as follows:
7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
*apache-calcite-1.29.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/amaliujia.asc
https://www.apache.org/dist/calcite/KEYS
To create the jars and test Apache Calcite: "gradle build" (requires an
appropriate Gradle/JDK installation).
Please vote on releasing this package as Apache Calcite 1.29.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.27.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Rui Wang <am...@apache.org>.
Thanks everyone for participating in the vote!
As of now we have received:
4 binding +1
Francis Chuang
Julian Hyde
Haisheng Yuan
Ruben Q L
2 non-binding +1
Xiong Duan
Alessandro Solimando
RC0 has passed the vote and I will follow up to get it released and get
release notes updated per suggestions.
-Rui
On Wed, Dec 22, 2021 at 7:23 AM Alessandro Solimando <
alessandro.solimando@gmail.com> wrote:
> Hello everyone,
> thank you Rui for all the work as a release manager!
>
> +1 (non-binding):
>
> - checked signature and checksum: OK
> - ./gradlew build (copied gradlew and gradle folder from "master"): OK
> - visual inspection of uploaded artifacts: OK
> - release notes: OK (but I agree with the observations made by the others)
> - diff -qr: OK (nothing relevant)
>
> $ sw_vers
> > ProductName: macOS
> > ProductVersion: 11.6
> > BuildVersion: 20G165
> > $ ./gradlew -version
>
>
> ------------------------------------------------------------
> > Gradle 7.3
> > ------------------------------------------------------------
>
> Build time: 2021-11-09 20:40:36 UTC
> > Revision: 96754b8c44399658178a768ac764d727c2addb37
>
> Kotlin: 1.5.31
> > Groovy: 3.0.9
> > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > JVM: 11.0.11 (AdoptOpenJDK 11.0.11+9)
>
> OS: Mac OS X 11.5 x86_64
>
>
> $ java -version
> > openjdk version "11.0.11" 2021-04-20
> > OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
> > OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed
> > mode)
>
>
> Best regards,
> Alessandro
>
>
> On Wed, 22 Dec 2021 at 10:27, Ruben Q L <ru...@gmail.com> wrote:
>
> > Thanks Rui for being our release manager this time.
> >
> > My vote is: +1 (binding)
> >
> > - Checksum and signature: ok
> > - Gradle test: ok
> > - Calcite-based application test suite: ok
> > - Release notes: ok, provided that fixes already mentioned get applied
> >
> > Best,
> > Ruben
> >
> >
> > On Wed, Dec 22, 2021 at 5:19 AM Haisheng Yuan <hy...@apache.org> wrote:
> >
> > > Thanks Rui for taking care of this release.
> > >
> > > - Verified GPG signature - OK
> > > - Verified SHA512 - OK
> > > - Checked release notes - OK
> > > - Ran gradle tests - OK
> > >
> > > Environment:
> > > macOS Big Sur, Java 17+35-LTS-2724
> > > Gradle 7.3
> > >
> > > +1 (binding)
> > >
> > > Thanks,
> > > Haisheng Yuan
> > >
> > > On 2021/12/21 01:27:01 Rui Wang wrote:
> > > > Hi all,
> > > >
> > > > I have created a build for Apache Calcite 1.29.0, release
> > > > candidate 0.
> > > >
> > > > Thanks to everyone who has contributed to this release.
> > > >
> > > > You can read the release notes here:
> > > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
> > > >
> > > > The commit to be voted upon:
> > > >
> > >
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> > > >
> > > > Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
> > > >
> > > > The artifacts to be voted on are located here:
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> > > > (revision 51667)
> > > >
> > > > The hashes of the artifacts are as follows:
> > > >
> > >
> >
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> > > > *apache-calcite-1.29.0-src.tar.gz
> > > >
> > > > A staged Maven repository is available for review at:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
> > > >
> > > >
> > > > Release artifacts are signed with the following key:
> > > > https://people.apache.org/keys/committer/amaliujia.asc
> > > > https://www.apache.org/dist/calcite/KEYS
> > > >
> > > > To create the jars and test Apache Calcite: "gradle build" (requires
> an
> > > > appropriate Gradle/JDK installation).
> > > >
> > > > Please vote on releasing this package as Apache Calcite 1.29.0.
> > > >
> > > > The vote is open for the next 72 hours and passes if a majority of at
> > > > least three +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Calcite 1.27.0
> > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > >
> >
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Alessandro Solimando <al...@gmail.com>.
Hello everyone,
thank you Rui for all the work as a release manager!
+1 (non-binding):
- checked signature and checksum: OK
- ./gradlew build (copied gradlew and gradle folder from "master"): OK
- visual inspection of uploaded artifacts: OK
- release notes: OK (but I agree with the observations made by the others)
- diff -qr: OK (nothing relevant)
$ sw_vers
> ProductName: macOS
> ProductVersion: 11.6
> BuildVersion: 20G165
> $ ./gradlew -version
------------------------------------------------------------
> Gradle 7.3
> ------------------------------------------------------------
Build time: 2021-11-09 20:40:36 UTC
> Revision: 96754b8c44399658178a768ac764d727c2addb37
Kotlin: 1.5.31
> Groovy: 3.0.9
> Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> JVM: 11.0.11 (AdoptOpenJDK 11.0.11+9)
OS: Mac OS X 11.5 x86_64
$ java -version
> openjdk version "11.0.11" 2021-04-20
> OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9)
> OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed
> mode)
Best regards,
Alessandro
On Wed, 22 Dec 2021 at 10:27, Ruben Q L <ru...@gmail.com> wrote:
> Thanks Rui for being our release manager this time.
>
> My vote is: +1 (binding)
>
> - Checksum and signature: ok
> - Gradle test: ok
> - Calcite-based application test suite: ok
> - Release notes: ok, provided that fixes already mentioned get applied
>
> Best,
> Ruben
>
>
> On Wed, Dec 22, 2021 at 5:19 AM Haisheng Yuan <hy...@apache.org> wrote:
>
> > Thanks Rui for taking care of this release.
> >
> > - Verified GPG signature - OK
> > - Verified SHA512 - OK
> > - Checked release notes - OK
> > - Ran gradle tests - OK
> >
> > Environment:
> > macOS Big Sur, Java 17+35-LTS-2724
> > Gradle 7.3
> >
> > +1 (binding)
> >
> > Thanks,
> > Haisheng Yuan
> >
> > On 2021/12/21 01:27:01 Rui Wang wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.29.0, release
> > > candidate 0.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> > >
> > > Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
> > >
> > > The artifacts to be voted on are located here:
> > >
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> > > (revision 51667)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> >
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> > > *apache-calcite-1.29.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
> > >
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/amaliujia.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite: "gradle build" (requires an
> > > appropriate Gradle/JDK installation).
> > >
> > > Please vote on releasing this package as Apache Calcite 1.29.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.27.0
> > > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> >
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Ruben Q L <ru...@gmail.com>.
Thanks Rui for being our release manager this time.
My vote is: +1 (binding)
- Checksum and signature: ok
- Gradle test: ok
- Calcite-based application test suite: ok
- Release notes: ok, provided that fixes already mentioned get applied
Best,
Ruben
On Wed, Dec 22, 2021 at 5:19 AM Haisheng Yuan <hy...@apache.org> wrote:
> Thanks Rui for taking care of this release.
>
> - Verified GPG signature - OK
> - Verified SHA512 - OK
> - Checked release notes - OK
> - Ran gradle tests - OK
>
> Environment:
> macOS Big Sur, Java 17+35-LTS-2724
> Gradle 7.3
>
> +1 (binding)
>
> Thanks,
> Haisheng Yuan
>
> On 2021/12/21 01:27:01 Rui Wang wrote:
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.29.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> >
> > Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
> >
> > The artifacts to be voted on are located here:
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> > (revision 51667)
> >
> > The hashes of the artifacts are as follows:
> >
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> > *apache-calcite-1.29.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
> >
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/amaliujia.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite: "gradle build" (requires an
> > appropriate Gradle/JDK installation).
> >
> > Please vote on releasing this package as Apache Calcite 1.29.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.27.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
> >
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Haisheng Yuan <hy...@apache.org>.
Thanks Rui for taking care of this release.
- Verified GPG signature - OK
- Verified SHA512 - OK
- Checked release notes - OK
- Ran gradle tests - OK
Environment:
macOS Big Sur, Java 17+35-LTS-2724
Gradle 7.3
+1 (binding)
Thanks,
Haisheng Yuan
On 2021/12/21 01:27:01 Rui Wang wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.29.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>
> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> (revision 51667)
>
> The hashes of the artifacts are as follows:
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> *apache-calcite-1.29.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/amaliujia.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build" (requires an
> appropriate Gradle/JDK installation).
>
> Please vote on releasing this package as Apache Calcite 1.29.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.27.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Francis Chuang <fr...@apache.org>.
My vote is: +1 (binding)
- Verified GPG signature - OK
- Verified SHA512 - OK
- Checked release notes
(https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md)
- OK
- Ran tests (gradle check) - OK
- Spot checked Nexus artifacts - OK
Environment:
Gradle 7.3.2 docker container in WSL2 (Ubuntu 20.04) on Windows 10 21h2
> docker version
Client: Docker Engine - Community
Cloud integration: v1.0.22
Version: 20.10.11
API version: 1.41
Go version: go1.16.9
Git commit: dea9396
Built: Thu Nov 18 00:37:33 2021
OS/Arch: linux/amd64
Context: default
Experimental: true
Server: Docker Engine - Community
Engine:
Version: 20.10.11
API version: 1.41 (minimum version 1.12)
Go version: go1.16.9
Git commit: 847da18
Built: Thu Nov 18 00:35:39 2021
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.4.12
GitCommit: 7b11cfaabd73bb80907dd23182b9347b4245eb5d
runc:
Version: 1.0.2
GitCommit: v1.0.2-0-g52b36a2
docker-init:
Version: 0.19.0
GitCommit: de40ad0
> gradle -v
------------------------------------------------------------
Gradle 7.3.2
------------------------------------------------------------
Build time: 2021-12-15 11:22:31 UTC
Revision: 26c186eb63b2b02e68d83b0dbc6ec69ab118653a
Kotlin: 1.5.31
Groovy: 3.0.9
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 17.0.1 (Eclipse Adoptium 17.0.1+12)
OS: Linux 5.10.60.1-microsoft-standard-WSL2 amd64
> java -version
openjdk version "17.0.1" 2021-10-19
OpenJDK Runtime Environment Temurin-17.0.1+12 (build 17.0.1+12)
OpenJDK 64-Bit Server VM Temurin-17.0.1+12 (build 17.0.1+12, mixed mode,
sharing)
Francis
On 21/12/2021 2:07 pm, xiong duan wrote:
> +1.
> But some notices:
> 1: [ ] +1 Release this package as Apache Calcite *1.29.0 *not 1.27.0
> 2: I have added typos in
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>
> Rui Wang <am...@apache.org> 于2021年12月21日周二 09:27写道：
>
>> Hi all,
>>
>> I have created a build for Apache Calcite 1.29.0, release
>> candidate 0.
>>
>> Thanks to everyone who has contributed to this release.
>>
>> You can read the release notes here:
>>
>> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>>
>> The commit to be voted upon:
>>
>> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>>
>> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>>
>> The artifacts to be voted on are located here:
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
>> (revision 51667)
>>
>> The hashes of the artifacts are as follows:
>>
>> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
>> *apache-calcite-1.29.0-src.tar.gz
>>
>> A staged Maven repository is available for review at:
>>
>> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>>
>>
>> Release artifacts are signed with the following key:
>> https://people.apache.org/keys/committer/amaliujia.asc
>> https://www.apache.org/dist/calcite/KEYS
>>
>> To create the jars and test Apache Calcite: "gradle build" (requires an
>> appropriate Gradle/JDK installation).
>>
>> Please vote on releasing this package as Apache Calcite 1.29.0.
>>
>> The vote is open for the next 72 hours and passes if a majority of at
>> least three +1 PMC votes are cast.
>>
>> [ ] +1 Release this package as Apache Calcite 1.27.0
>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>> [ ] -1 Do not release this package because...
>>
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by xiong duan <no...@gmail.com>.
+1.
But some notices:
1: [ ] +1 Release this package as Apache Calcite *1.29.0 *not 1.27.0
2: I have added typos in
https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
Rui Wang <am...@apache.org> 于2021年12月21日周二 09:27写道：
> Hi all,
>
> I have created a build for Apache Calcite 1.29.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
>
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
>
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>
> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> (revision 51667)
>
> The hashes of the artifacts are as follows:
>
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> *apache-calcite-1.29.0-src.tar.gz
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/amaliujia.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build" (requires an
> appropriate Gradle/JDK installation).
>
> Please vote on releasing this package as Apache Calcite 1.29.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.27.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Julian Hyde <jh...@gmail.com>.
Yes, push a commit right after the release. If you look at the history in git you will see that there are always one or two commits after each release, e.g. fixing the release date, publishing javadoc, updating howto.
> On Dec 21, 2021, at 12:22 PM, Rui Wang <am...@apache.org> wrote:
>
> Hi Julian,
>
> What is the proper way to fix release note/documentation
> suggestions given RC0 is under voting (I guess that does not require a RC1
> cut)?
>
> just push a new commit later to fix those things?
>
> -Rui
>
> On Mon, Dec 20, 2021 at 8:29 PM Julian Hyde <jhyde.apache@gmail.com <ma...@gmail.com>> wrote:
>
>> Fixing the problem in the vote email previously noted by xiong duan:
>>
>> [ ] +1 Release this package as Apache Calcite 1.29.0
>>
>> +1
>>
>> Downloaded, checked hashes and signatures; compared files with git;
>> checked LICENSE, NOTICE; ensured no binaries in the tarball; built on
>> Ubuntu Linux, JDK 15 and Gradle 7.2 (per howto.md).
>>
>> Other remarks:
>> * howto.md should say Gradle 7.3 (since that’s out current Gradle version)
>> but says 7.2
>> * I guess we now support JDK 16 and 17? According to the release notes, we
>> only go up to JDK 15.
>> * The commit message of
>> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>> <
>> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e <https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e>>
>> should not end in ‘.’.
>> * The release notes need significant work:
>> * For contributors, list only names (not email addresses), remove
>> duplicates, and end each line with ‘,’ (last line with ‘.’)
>> * Change lines should not end in ‘,’
>> * Add a ‘New features’ section
>> * In the change lines, manually put backticks around references such as
>> ARRAY_CONCAT and SqlBasicCall
>> * Use editorial discretion to make the release notes clearer. For
>> example, it is confusing that the release notes includes 'Revert
>> Elasticsearch to 7.10.2’ without mentioning the previous upgrade. I would
>> say ‘Upgrade Elasticsearch to 7.10.2’. Also omit the ‘ Upgrade log4j2
>> version to 2.15.0’ and 'Upgrade log4j2 version to 2.16.0’ lines, because
>> they are superseded.
>> * 'Build gives lots of 'Execution optimizations have been disabled'
>> warnings,’ should be in ‘Build’ section
>> * We need more of a ‘headline’ than 'This release comes two months after
>> 1.28.0, contains contributions from 23 authors, and resolves 47 issues’ . I
>> would definitely mention the upgrade to log4j2. Others at your discretion.
>>
>> Julian
>>
>>
>>> On Dec 20, 2021, at 5:27 PM, Rui Wang <am...@apache.org> wrote:
>>>
>>> Hi all,
>>>
>>> I have created a build for Apache Calcite 1.29.0, release
>>> candidate 0.
>>>
>>> Thanks to everyone who has contributed to this release.
>>>
>>> You can read the release notes here:
>>>
>> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>>>
>>> The commit to be voted upon:
>>>
>> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>>>
>>> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>>>
>>> The artifacts to be voted on are located here:
>>>
>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
>>> (revision 51667)
>>>
>>> The hashes of the artifacts are as follows:
>>>
>> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
>>> *apache-calcite-1.29.0-src.tar.gz
>>>
>>> A staged Maven repository is available for review at:
>>>
>> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>>>
>>>
>>> Release artifacts are signed with the following key:
>>> https://people.apache.org/keys/committer/amaliujia.asc
>>> https://www.apache.org/dist/calcite/KEYS
>>>
>>> To create the jars and test Apache Calcite: "gradle build" (requires an
>>> appropriate Gradle/JDK installation).
>>>
>>> Please vote on releasing this package as Apache Calcite 1.29.0.
>>>
>>> The vote is open for the next 72 hours and passes if a majority of at
>>> least three +1 PMC votes are cast.
>>>
>>> [ ] +1 Release this package as Apache Calcite 1.27.0
>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release
>>> [ ] -1 Do not release this package because...
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Rui Wang <am...@apache.org>.
Hi Julian,
What is the proper way to fix release note/documentation
suggestions given RC0 is under voting (I guess that does not require a RC1
cut)?
just push a new commit later to fix those things?
-Rui
On Mon, Dec 20, 2021 at 8:29 PM Julian Hyde <jh...@gmail.com> wrote:
> Fixing the problem in the vote email previously noted by xiong duan:
>
> [ ] +1 Release this package as Apache Calcite 1.29.0
>
> +1
>
> Downloaded, checked hashes and signatures; compared files with git;
> checked LICENSE, NOTICE; ensured no binaries in the tarball; built on
> Ubuntu Linux, JDK 15 and Gradle 7.2 (per howto.md).
>
> Other remarks:
> * howto.md should say Gradle 7.3 (since that’s out current Gradle version)
> but says 7.2
> * I guess we now support JDK 16 and 17? According to the release notes, we
> only go up to JDK 15.
> * The commit message of
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> <
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e>
> should not end in ‘.’.
> * The release notes need significant work:
> * For contributors, list only names (not email addresses), remove
> duplicates, and end each line with ‘,’ (last line with ‘.’)
> * Change lines should not end in ‘,’
> * Add a ‘New features’ section
> * In the change lines, manually put backticks around references such as
> ARRAY_CONCAT and SqlBasicCall
> * Use editorial discretion to make the release notes clearer. For
> example, it is confusing that the release notes includes 'Revert
> Elasticsearch to 7.10.2’ without mentioning the previous upgrade. I would
> say ‘Upgrade Elasticsearch to 7.10.2’. Also omit the ‘ Upgrade log4j2
> version to 2.15.0’ and 'Upgrade log4j2 version to 2.16.0’ lines, because
> they are superseded.
> * 'Build gives lots of 'Execution optimizations have been disabled'
> warnings,’ should be in ‘Build’ section
> * We need more of a ‘headline’ than 'This release comes two months after
> 1.28.0, contains contributions from 23 authors, and resolves 47 issues’ . I
> would definitely mention the upgrade to log4j2. Others at your discretion.
>
> Julian
>
>
> > On Dec 20, 2021, at 5:27 PM, Rui Wang <am...@apache.org> wrote:
> >
> > Hi all,
> >
> > I have created a build for Apache Calcite 1.29.0, release
> > candidate 0.
> >
> > Thanks to everyone who has contributed to this release.
> >
> > You can read the release notes here:
> >
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
> >
> > The commit to be voted upon:
> >
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
> >
> > Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
> >
> > The artifacts to be voted on are located here:
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> > (revision 51667)
> >
> > The hashes of the artifacts are as follows:
> >
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> > *apache-calcite-1.29.0-src.tar.gz
> >
> > A staged Maven repository is available for review at:
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
> >
> >
> > Release artifacts are signed with the following key:
> > https://people.apache.org/keys/committer/amaliujia.asc
> > https://www.apache.org/dist/calcite/KEYS
> >
> > To create the jars and test Apache Calcite: "gradle build" (requires an
> > appropriate Gradle/JDK installation).
> >
> > Please vote on releasing this package as Apache Calcite 1.29.0.
> >
> > The vote is open for the next 72 hours and passes if a majority of at
> > least three +1 PMC votes are cast.
> >
> > [ ] +1 Release this package as Apache Calcite 1.27.0
> > [ ] 0 I don't feel strongly about it, but I'm okay with the release
> > [ ] -1 Do not release this package because...
>
>
Re: [VOTE] Release apache-calcite-1.29.0 (release candidate 0)
Posted by Julian Hyde <jh...@gmail.com>.
Fixing the problem in the vote email previously noted by xiong duan:
[ ] +1 Release this package as Apache Calcite 1.29.0
+1
Downloaded, checked hashes and signatures; compared files with git; checked LICENSE, NOTICE; ensured no binaries in the tarball; built on Ubuntu Linux, JDK 15 and Gradle 7.2 (per howto.md).
Other remarks:
* howto.md should say Gradle 7.3 (since that’s out current Gradle version) but says 7.2
* I guess we now support JDK 16 and 17? According to the release notes, we only go up to JDK 15.
* The commit message of https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e <https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e> should not end in ‘.’.
* The release notes need significant work:
* For contributors, list only names (not email addresses), remove duplicates, and end each line with ‘,’ (last line with ‘.’)
* Change lines should not end in ‘,’
* Add a ‘New features’ section
* In the change lines, manually put backticks around references such as ARRAY_CONCAT and SqlBasicCall
* Use editorial discretion to make the release notes clearer. For example, it is confusing that the release notes includes 'Revert Elasticsearch to 7.10.2’ without mentioning the previous upgrade. I would say ‘Upgrade Elasticsearch to 7.10.2’. Also omit the ‘ Upgrade log4j2 version to 2.15.0’ and 'Upgrade log4j2 version to 2.16.0’ lines, because they are superseded.
* 'Build gives lots of 'Execution optimizations have been disabled' warnings,’ should be in ‘Build’ section
* We need more of a ‘headline’ than 'This release comes two months after 1.28.0, contains contributions from 23 authors, and resolves 47 issues’ . I would definitely mention the upgrade to log4j2. Others at your discretion.
Julian
> On Dec 20, 2021, at 5:27 PM, Rui Wang <am...@apache.org> wrote:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.29.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
> https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e
>
> Its hash is cbfe0609edcc4a843d71497f159e3687a834119e
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/
> (revision 51667)
>
> The hashes of the artifacts are as follows:
> 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3
> *apache-calcite-1.29.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/
>
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/amaliujia.asc
> https://www.apache.org/dist/calcite/KEYS
>
> To create the jars and test Apache Calcite: "gradle build" (requires an
> appropriate Gradle/JDK installation).
>
> Please vote on releasing this package as Apache Calcite 1.29.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.27.0
> [ ] 0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...