[GitHub] [pulsar] Anonymitaet commented on a change in pull request #5199: [Doc] Add configuration of Flume source connector

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #5199: [Doc] Add configuration of Flume source connector
URL: https://github.com/apache/pulsar/pull/5199#discussion_r324975739
 
 

 ##########
 File path: site2/docs/io-flume-source.md
 ##########
 @@ -0,0 +1,21 @@
+---
+id: io-flume-source
+title: Flume source connector
+sidebar_label: Flume source connector
+---
+
+The Flume source connector pulls messages from logs to Pulsar topics.
+
+## Configuration
+
+The configuration of Flume source connector has the following parameters.
+
+### Parameter
+
+| Name | Type|Required | Default | Description 
+|------|----------|----------|---------|-------------|
+`name`|String|true|"" (empty string)|Name of the agent
+`confFile`|String|true|"" (empty string)|Configuration file
+`noReloadConf`|Boolean||false|Whether to reload configuration file if changed
 
 Review comment:
   @tuteng Is `noReloadConf` required or optional? I don't find the information in https://github.com/apache/pulsar/blob/master/pulsar-io/flume/src/main/java/org/apache/pulsar/io/flume/FlumeConfig.java

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services