You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/03/07 02:54:01 UTC
Review Request 18885: Fixed SystemCpuUsage isolator test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18885/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1062
https://issues.apache.org/jira/browse/MESOS-1062
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/tests/isolator_tests.cpp 18d67c7ab6500c4963ee601e7324d85cebfbfef5
Diff: https://reviews.apache.org/r/18885/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 18885: Fixed SystemCpuUsage isolator test.
Posted by Vinod Kone <vi...@gmail.com>.
> On March 7, 2014, 2:04 a.m., Ben Mahler wrote:
> > src/tests/isolator_tests.cpp, lines 191-192
> > <https://reviews.apache.org/r/18885/diff/1/?file=513299#file513299line191>
> >
> > Do you want the same thing here?
good catch. will kill it before i commit it.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18885/#review36475
-----------------------------------------------------------
On March 7, 2014, 1:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18885/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 1:54 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1062
> https://issues.apache.org/jira/browse/MESOS-1062
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/isolator_tests.cpp 18d67c7ab6500c4963ee601e7324d85cebfbfef5
>
> Diff: https://reviews.apache.org/r/18885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 18885: Fixed SystemCpuUsage isolator test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18885/#review36475
-----------------------------------------------------------
Ship it!
src/tests/isolator_tests.cpp
<https://reviews.apache.org/r/18885/#comment67461>
Do you want the same thing here?
- Ben Mahler
On March 7, 2014, 1:54 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18885/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 1:54 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1062
> https://issues.apache.org/jira/browse/MESOS-1062
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/isolator_tests.cpp 18d67c7ab6500c4963ee601e7324d85cebfbfef5
>
> Diff: https://reviews.apache.org/r/18885/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>