You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MrPowers (via GitHub)" <gi...@apache.org> on 2024/01/20 15:56:33 UTC
[PR] [WIP] docs: restructure the docs index page [spark]
MrPowers opened a new pull request, #44812:
URL: https://github.com/apache/spark/pull/44812
### What changes were proposed in this pull request?
The [Spark docs index](https://spark.apache.org/docs/latest/) page hasn't been updated in a while and this PR cleans up the language and shifts the examples from RDDs => DataFrames.
If this PR gets merged, I would like to take another stab and give even more detailed installation instructions. Showing users how to run scripts from the command line is cool, but I think it would also be nice to explain how to include Spark in a Python project and run a Jupyter notebook with Spark.
### Why are the changes needed?
We'd like to encourage users to use DataFrames instead of RDDs.
This post ranks for "spark install" searches and we would also like to make it easier for users to install Spark.
### Does this PR introduce _any_ user-facing change?
No user facing code changes, but this would be user facing docs changes.
### How was this patch tested?
Ran the code locally.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] docs: restructure the docs index page [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44812:
URL: https://github.com/apache/spark/pull/44812#discussion_r1471502362
##########
docs/index.md:
##########
@@ -20,27 +20,23 @@ license: |
limitations under the License.
---
-# Downloading
+## Downloading
-Get Spark from the [downloads page](https://spark.apache.org/downloads.html) of the project website. This documentation is for Spark version {{site.SPARK_VERSION}}. Spark uses Hadoop's client libraries for HDFS and YARN. Downloads are pre-packaged for a handful of popular Hadoop versions.
Review Comment:
I know this is still a WIP, but I would keep the mention of `{{site.SPARK_VERSION}}` somewhere prominent in the revised text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP] docs: restructure the docs index page [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #44812:
URL: https://github.com/apache/spark/pull/44812#issuecomment-1917320602
Looks good - ideally post a little before and after screenshot (or, just after)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org