[GitHub] [flink] echauchot commented on a diff in pull request #22985: [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler

["echauchot (via GitHub)" <gi...@apache.org>]

echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1287009835


##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -488,6 +488,23 @@ public enum SchedulerType {
                                             code(SchedulerExecutionMode.REACTIVE.name()))
                                     .build());
 
+    @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+    public static final ConfigOption<Long> SCHEDULER_SCALING_INTERVAL_MIN =
+            key("jobmanager.adaptive-scheduler.scaling-interval.min")
+                    .longType()
+                    .defaultValue(30L) // favor lower scaling-interval.min for more reactive
+                    // rescaling and let the user increase the value for high workloads
+                    .withDescription(
+                            "Determines the minimum time (in seconds) between scaling operations in reactive mode.");
+
+    @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+    public static final ConfigOption<Long> SCHEDULER_SCALING_INTERVAL_MAX =
+            key("jobmanager.adaptive-scheduler.scaling-interval.max")
+                    .longType()
+                    .noDefaultValue()
+                    .withDescription(
+                            "Allow the user to configure the time (in seconds) after which a scaling operation is triggered regardless if the requirements are met");

Review Comment:
   :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org