You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/28 12:52:57 UTC
[GitHub] [airflow] turbaszek opened a new pull request #14528: Make airflow info to work with pipes
turbaszek opened a new pull request #14528:
URL: https://github.com/apache/airflow/pull/14528
Closes: #14518
<img width="1680" alt="Screenshot 2021-02-28 at 13 51 53" src="https://user-images.githubusercontent.com/9528307/109419118-2078a980-79cc-11eb-8349-b75c3e55a938.png">
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14528: Make airflow info to work with pipes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14528:
URL: https://github.com/apache/airflow/pull/14528#issuecomment-787450945
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14528: Make airflow info to work with pipes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14528:
URL: https://github.com/apache/airflow/pull/14528#discussion_r584291733
##########
File path: airflow/cli/simple_table.py
##########
@@ -30,6 +31,11 @@
class AirflowConsole(Console):
"""Airflow rich console"""
+ def __init__(self, *args, **kwargs):
+ super(AirflowConsole, self).__init__(*args, **kwargs)
+ # Set the width to constant to pipe whole output from console
+ self._width = 200 if not sys.stdout.isatty() else self._width
Review comment:
Can you use `airflow.utils.platform.is_tty` here? isatty doesn't always exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #14528: Make airflow info to work with pipes
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #14528:
URL: https://github.com/apache/airflow/pull/14528
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #14528: Make airflow info to work with pipes
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #14528:
URL: https://github.com/apache/airflow/pull/14528#discussion_r584297598
##########
File path: airflow/cli/commands/cheat_sheet_command.py
##########
@@ -14,13 +14,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
from typing import Iterable, List, Optional, Union
-from rich.console import Console
-
from airflow.cli.cli_parser import ActionCommand, GroupCommand, airflow_commands
-from airflow.cli.simple_table import SimpleTable
+from airflow.cli.simple_table import SimpleTable, AirflowConsole
Review comment:
```suggestion
from airflow.cli.simple_table import AirflowConsole, SimpleTable
```
##########
File path: airflow/cli/commands/info_command.py
##########
@@ -27,10 +27,9 @@
import requests
import tenacity
-from rich.console import Console
from airflow import configuration
-from airflow.cli.simple_table import SimpleTable
+from airflow.cli.simple_table import SimpleTable, AirflowConsole
Review comment:
```suggestion
from airflow.cli.simple_table import AirflowConsole, SimpleTable
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org